Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into merging trait definitions and macro code together. #1123

Open
ruseinov opened this issue Dec 19, 2023 · 5 comments
Open

Look into merging trait definitions and macro code together. #1123

ruseinov opened this issue Dec 19, 2023 · 5 comments
Assignees

Comments

@ruseinov
Copy link
Collaborator

For everything that is defined in near-sdk-macros/src/core_impl/code_generator. Perhaps a good approach could be to introduce a code_generator module for each trait in their respective modules.

Originally posted by @frol in #1118 (comment)

@frol
Copy link
Collaborator

frol commented Jul 29, 2024

On second thought, someone would need to look into the project structure and make a call on what would be the best way to resolve this structuring puzzle. I think it does not require deep NEAR understanding, so I mark this issue as good-first-issue for someone to potentially play around it, but it is not a high-priority issue by any means.

@frol frol added good first issue Good for newcomers ODHack labels Jul 29, 2024
@ruseinov
Copy link
Collaborator Author

Sounds good! Let's see if someone wants to attack this.

@IjayAbby
Copy link

Hey @ruseinov can I give it a shot see what I can come up with?

@IjayAbby
Copy link

IjayAbby commented Jul 30, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have an understanding in both Rust and Python and would love to stretch out my rust skills a bit. Am not familiar with NEAR but I can work around it.

How I plan on tackling this issue

Work closely with the project maintainer to see how best I can resolve the issue with existing ideas in place. Would love to give it a shot.

@frol
Copy link
Collaborator

frol commented Jul 30, 2024

@IjayAbby Sure, give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants