Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Implementation of weights is occasionally unclear #578

Open
calebweinreb opened this issue Jun 28, 2024 · 1 comment
Open

[JOSS] Implementation of weights is occasionally unclear #578

calebweinreb opened this issue Jun 28, 2024 · 1 comment

Comments

@calebweinreb
Copy link

Re JOSS review openjournals/joss-reviews#6889

A big strength of scores is the ability to incorporate weights into many of the metrics. But how exactly these weights are incorporated is often unclear. Though the application of weights is obvious in come cases (e.g. RMSE), I don't have any intuition for how weights be used roc_curve_data, for example. In these ambiguous cases the docstring should be updated to provide a clearer explanation.

@tennlee
Copy link
Collaborator

tennlee commented Jun 30, 2024

That makes sense. It will take some time, but I will work through each score/metric and check if there is an example of the weights presented in each notebook as well as checking the docstrings to provide an indication. If you notice any others you think are particularly ambiguous, feel free to drop a note here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants