Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Upgrade JUnit, JMock with test files #793

Closed
wants to merge 2 commits into from

Conversation

cheesecrust
Copy link
Collaborator

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

  • JUnit 4.13.1 -> JUnit 5.10.2 version upgrade
  • JMock 1.2.0 -> JMock 2.13.1 version upgrade

JUnit ์—…๊ทธ๋ ˆ์ด๋“œ

JUnit ์„ ๋ฒ„์ „ 5๋กœ ์—…๊ทธ๋ ˆ์ด๋“œ ํ•˜๋ฉด์„œ ์ฝ”๋“œ์˜ ๋ณ€๊ฒฝ์„ ์ตœ์†Œํ™” ํ•˜๊ธฐ ์œ„ํ•ด vintage engine ์„ ์ถ”๊ฐ€ํ•˜์—ฌ JUnit 3, 4 ์˜ ๋ฌธ๋ฒ•์ด ํ˜ธํ™˜๋˜๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

JMock ์—…๊ทธ๋ ˆ์ด๋“œ

JMock1 ์„ JMock2 ๋กœ ์—…๊ทธ๋ ˆ์ด๋“œ ํ•˜๋ฉด์„œ ๋ช‡๋ช‡ ๋ถ€๋ถ„์„ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

  • MockObjectTestCase -> TestCase

  • ๊ธฐ๋Œ“๊ฐ’ ์„ค์ • ๋ฌธ๋ฒ• ๋ณ€๊ฒฝ

๊ธฐ์กด

clientMock.expects(once()).method("getTranscoder")
            .will(returnValue(transcoder));

๋ณ€๊ฒฝ ํ›„

context.checking(
            new Expectations() {{
              oneOf(client).getTranscoder();
              will(returnValue(transcoder));
            }}
    );

@oliviarla
Copy link
Collaborator

@cheesecrust
ํ˜„์žฌ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ์˜ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์€ jmock์˜ ์—…๊ทธ๋ ˆ์ด๋“œ๋กœ ์ธํ•ด ๋ฐœ์ƒํ•œ ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค. ์ด๋ฒˆ PR์—์„œ๋Š” jmock์˜ ๋ฒ„์ „๋งŒ ์—…๊ทธ๋ ˆ์ด๋“œํ•˜๋„๋ก ํ•˜๊ณ , ๋‹ค์Œ PR๋กœ junit ๋ฒ„์ „ ์—…๊ทธ๋ ˆ์ด๋“œ์™€ ๊ด€๋ จ๋œ ๋‚ด์šฉ์„ ์˜ฌ๋ ค์ฃผ์„ธ์š”.

๋‹ค์Œ PR์—์„œ๋Š” vintage engine ์‚ฌ์šฉํ•˜์ง€ ์•Š๊ณ  ์ธํ„ฐํŽ˜์ด์Šค ๋ณ€ํ™”์— ๋งž์ถฐ ๋ณ€๊ฒฝํ•œ ํ›„ junit-jupiter-api, junit-jupiter-engine ์˜์กด์„ฑ๋งŒ ๊ฐ€์ง€๋„๋ก ํ•˜๋ฉด ๋ฉ๋‹ˆ๋‹ค.

@cheesecrust cheesecrust marked this pull request as draft August 14, 2024 06:36
@cheesecrust cheesecrust force-pushed the internal/junit5 branch 9 times, most recently from 42f7bc6 to 6d0f0b4 Compare August 19, 2024 08:51
@cheesecrust cheesecrust marked this pull request as ready for review August 19, 2024 08:55
@cheesecrust cheesecrust deleted the internal/junit5 branch September 24, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants