TEST: Fix java.net.spy.memcached.protocol.ascii.BaseOpTest to ensure it tests correctly.
#791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
force-pushed
the
uhm0311/develop5
branch
from
6215240
to
0272c2e
Compare
uhm0311
changed the title
net.spy.memcached.protocol.ascii.BaseOpTest to ensure it tests correctly.java.net.spy.memcached.protocol.ascii.BaseOpTest to ensure it tests correctly.
uhm0311
force-pushed
the
uhm0311/develop5
branch
from
0272c2e
to
a13ba26
Compare
|
CI μ€ν¨λ μ PRμ΄ λ¨Όμ λ°μλμ΄μΌ ν©λλ€. |
uhm0311
force-pushed
the
uhm0311/develop5
branch
from
a13ba26
to
9d19a5c
Compare
oliviarla
reviewed
Aug 12, 2024
| /** | ||
| * Test the basic operation buffer handling stuff. | ||
| */ | ||
| public class BaseOpTest extends BaseMockCase { | ||
|
|
||
| public void testAssertions() { | ||
| String message = "Assertions are not enabled."; | ||
| AssertionError error = null; | ||
| try { |
There was a problem hiding this comment.
Assertions.assertThrows(AssertionError.class, () -> {assert false;}) μ κ°μ΄ λ³κ²½ν μ μλμ? fail() λΆλΆμ μ κ±°νκ³ μ
uhm0311
force-pushed
the
uhm0311/develop5
branch
3 times, most recently
from
9481bd8
to
d1c9870
Compare
β¦e it tests correctly.
uhm0311
force-pushed
the
uhm0311/develop5
branch
from
d1c9870
to
e00af58
Compare
oliviarla
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Related Issue
assertλ¬Έμ μν μ€ν¨λ μ‘κ³ fail() λ©μλμ μν μ€ν¨λ μ‘λλ°, μ‘μλμ μ€ν¨κ° 무μμΈμ§ νμΈνμ§ μκ³ μλ€.β¨οΈ What I did