INTERNA: Change callback method for mutate operation. #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brido4125
force-pushed
the
internal/mutateCallback
branch
from
7d65522
to
958a253
Compare
uhm0311
requested changes
Jul 15, 2024
| })); | ||
|
|
||
| @Override | ||
| public void gotMutatedValue(Long result) { |
| /** | ||
| * Callback for mutate operation. | ||
| * | ||
| * @param result the value that was mutated. |
There was a problem hiding this comment.
주석도 변화량을 매개변수로 넣어줘야 한다는 점을 더욱 명확하게 나타내는 문장으로 바꾸고요.
|
아래 코멘트에 의해서 PR close 하고 https://github.com/jam2in/arcus-works/issues/584#issuecomment-2235803311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 내용
mutate의 연산 결과를 receivedStatus가 아닌
gotMutatedValue 콜백 메서드를 추가해 이를 통해
받아오도록 변경하였습니다.
관련 이슈
https://github.com/jam2in/arcus-works/issues/584#issuecomment-2216229651