Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video saving into Picture folder #236

Open
4 tasks done
Riz1ahmed opened this issue Sep 24, 2024 · 7 comments
Open
4 tasks done

Video saving into Picture folder #236

Riz1ahmed opened this issue Sep 24, 2024 · 7 comments
Assignees

Comments

@Riz1ahmed
Copy link

Riz1ahmed commented Sep 24, 2024

Did you check the documentation and it did not help?

When I am saving video with an album name (e.g. await Gal.putVideo(tmpVideoPath.path, album: 'Intro Maker');) the video saving into 'Picture/Intro Maker' directory.

My phone is a Galaxy s8, android v10 (Custom ROM).

@Riz1ahmed Riz1ahmed added 🐝 bug Something isn't working 👀 in triage This issue or pull request is in triage labels Sep 24, 2024
@natsuk4ze
Copy link
Owner

We cannot respond until the DESCRIPTION item is filled

@natsuk4ze natsuk4ze added 💬 waiting for response Without additional info, bot will close this issue and removed 🐝 bug Something isn't working labels Sep 24, 2024
@natsuk4ze
Copy link
Owner

This behavior is currently as intended.

@natsuk4ze natsuk4ze removed the 👀 in triage This issue or pull request is in triage label Sep 24, 2024
@Riz1ahmed
Copy link
Author

Riz1ahmed commented Sep 24, 2024

What I will give in the description?


Now I have checked your inner code. In native you called same for both video and image

GalPlugin.java (line63)

switch (call.method) { case "putVideo": case "putImage": { new Thread(() -> { try {

And in the createContentValues method The condition Is (I think not right).

GalPlugin.java (line167)

private ContentValues createContentValues(boolean isImage, String name, String extension,
            String album) {
        ContentValues values = new ContentValues();
        String dirPath = isImage || album != null ? Environment.DIRECTORY_PICTURES
                : Environment.DIRECTORY_MOVIES;
 ......

Here set Environment.DIRECTORY_PICTURES if album null. But I have passed album value

@natsuk4ze
Copy link
Owner

natsuk4ze commented Sep 24, 2024

What I will give in the description?

Simply fill in the items as per the template. You have erased it and it is no longer visible.

@Riz1ahmed
Copy link
Author

Now I have commented. Please check

@natsuk4ze
Copy link
Owner

When specifying a custom album, it is intended that it be created under Picture. I don't remember, but I think there was a reason it couldn't be created under Video🤔

@Riz1ahmed
Copy link
Author

Riz1ahmed commented Sep 24, 2024

After removing the album != null from the createContentValues method, The video has been saved in the 'Movies/Intro Maker' directory. So I think it is possible

And it is not good practice to use your code by changing on my side as there could be more conditions I don't know.

So please handle it

@natsuk4ze natsuk4ze removed the 💬 waiting for response Without additional info, bot will close this issue label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants