Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DefaultCacheBufferExpiration configurable to prevent OOM in small system at high pub and sub rates #5740

Open
roeschter opened this issue Aug 2, 2024 · 0 comments
Assignees
Labels
proposal Enhancement idea or proposal stale This issue has had no activity in a while

Comments

@roeschter
Copy link

Proposed change

Make DefaultCacheBufferExpiration filestore.go configurable at server start

Use case

DefaultCacheBufferExpiration defaults to 10s - in certain situations (most commonly WorkQueues) all blocks reads in a stream for 10s will be cached. This can easily amount to several GB of rapid memory growth, resulting in an unexpected OOM.

We are aware that reducing DefaultCacheBufferExpiration can impact throughput.

It is a valid use case for small systems to consume or send data in bursts. The memory consumption should be bounded though as the data is streaming through the system. Reducing the DefaultCacheBufferExpiration will also throttle the system, which is a desirable side effect.

Also see:
#5673
#5739

Contribution

No response

@roeschter roeschter added the proposal Enhancement idea or proposal label Aug 2, 2024
@derekcollison derekcollison self-assigned this Aug 2, 2024
@github-actions github-actions bot added the stale This issue has had no activity in a while label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal stale This issue has had no activity in a while
Projects
None yet
Development

No branches or pull requests

2 participants