-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question on releases #396
Comments
So you guys just pushed a new release, and looking at the |
@wallyqs It looks like you're the one that actually pushed the last version of that image - any chance you can do it again (or set up automation to do it on release)? |
@jbury yes hoping to tackle this soon... |
@wallyqs Looks like that image is still out of date. Is there anything I can do to help you guys get some automation in place to do a regular-cadence release of that image? Or, alternatively, is the plan to just sunset it altogether in lieu of pure helm deployments? You mentioned here: #409 that you plan to remove some of the non-helm setup cruft, but I don't know if that means this image is going away too. |
@jbury those scripts were pre-Helm 3 release and so far that approach has been faring better, so now I think we should clean up those setup scripts and only leave the Helm parts in this repo probably... |
Sounds good. I'll leave that cleanup to you then? Unsure if there's docs that need updating along with it. As an aside, I really dislike using helm directly, so I'll probably be pushing some MRs your way to make it more usable via indirect helm invocations :) Feel free to close this issue if you'd like, or keep it open as a reminder to clean up ye olde scripts. Cheers! |
Dunno what, if anything, you'll want to do with the image referenced in this issue - but just popping a reminder to deprecate that bad boy too, since it's already out of date as is. |
I got a PR merged in a bit ago (
https://github.com/nats-io/k8s/pull/394
) that should add some functionality to the NATS setup image.Currently I'm using a setup script that is based on the script found at
https://nats-io.github.io/k8s/setup.sh
, and it references the NATS setup image atsynadia/nats-setup:0.1.6
. I'm wondering if/when the PR I merged in above will be available in a pre-built docker image, and whether or not I'll need to update the version I'm pointing to in my setup.sh script to pull that change in. Do I need to wait for a release? Is there a cicd pipeline building that image out for consumption somewhere?Any guidance on this?
The text was updated successfully, but these errors were encountered: