Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on releases #396

Open
jbury opened this issue Jan 1, 2022 · 7 comments
Open

Question on releases #396

jbury opened this issue Jan 1, 2022 · 7 comments

Comments

@jbury
Copy link
Contributor

jbury commented Jan 1, 2022

I got a PR merged in a bit ago (https://github.com/nats-io/k8s/pull/394) that should add some functionality to the NATS setup image.

Currently I'm using a setup script that is based on the script found at https://nats-io.github.io/k8s/setup.sh, and it references the NATS setup image at synadia/nats-setup:0.1.6. I'm wondering if/when the PR I merged in above will be available in a pre-built docker image, and whether or not I'll need to update the version I'm pointing to in my setup.sh script to pull that change in. Do I need to wait for a release? Is there a cicd pipeline building that image out for consumption somewhere?

Any guidance on this?

@jbury
Copy link
Contributor Author

jbury commented Jan 11, 2022

So you guys just pushed a new release, and looking at the synadia/nats-setup image on Dockerhub, no updates have been pushed in almost 2 years. Is this image no longer being mantained/updated? Is this just a miss in the automation? Can we get it updated with the latest-and-greatest from the setup dir?

@jbury
Copy link
Contributor Author

jbury commented Jan 11, 2022

@wallyqs It looks like you're the one that actually pushed the last version of that image - any chance you can do it again (or set up automation to do it on release)?

@wallyqs
Copy link
Member

wallyqs commented Jan 11, 2022

@jbury yes hoping to tackle this soon...

@jbury
Copy link
Contributor Author

jbury commented Aug 13, 2022

@wallyqs Looks like that image is still out of date. Is there anything I can do to help you guys get some automation in place to do a regular-cadence release of that image? Or, alternatively, is the plan to just sunset it altogether in lieu of pure helm deployments?

You mentioned here: #409 that you plan to remove some of the non-helm setup cruft, but I don't know if that means this image is going away too.

@wallyqs
Copy link
Member

wallyqs commented Aug 13, 2022

@jbury those scripts were pre-Helm 3 release and so far that approach has been faring better, so now I think we should clean up those setup scripts and only leave the Helm parts in this repo probably...

@jbury
Copy link
Contributor Author

jbury commented Aug 14, 2022

Sounds good. I'll leave that cleanup to you then? Unsure if there's docs that need updating along with it.

As an aside, I really dislike using helm directly, so I'll probably be pushing some MRs your way to make it more usable via indirect helm invocations :) Feel free to close this issue if you'd like, or keep it open as a reminder to clean up ye olde scripts.

Cheers!

@jbury
Copy link
Contributor Author

jbury commented Aug 14, 2022

Dunno what, if anything, you'll want to do with the image referenced in this issue - but just popping a reminder to deprecate that bad boy too, since it's already out of date as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants