Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide disappears/height problem with bootstrap/hide (possible fix included) #566

Open
foxx opened this issue Jan 24, 2014 · 0 comments
Open

Comments

@foxx
Copy link

foxx commented Jan 24, 2014

When using hidden-* in bootstrap to show/hide an element containing a slideshow, the slide does not re-appear again.

This is due to;

      height = (this.options.height / this.options.width) * width;
      this.options.height = height;

The only fix I could find so far was to add;

      height = (this.options.height / this.options.width) * width;

      if (!height) {
        return;
      }

Please let me know if this approach is accepted, if so I will send a PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant