Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot doesn't allow injection of a FileSystem to use for the snapshot destination #31

Open
dkincaid opened this issue May 21, 2013 · 2 comments

Comments

@dkincaid
Copy link
Contributor

The Pail.create() methods allow a FileSystem to be used in the creation of the pail. However, when creating a snapshot of a pail the only option is to include the FileSystem in the path string that is passed in for the destination. In order to keep consistency, all the methods that create a new Pail at a new path should allow a FileSystem to be given separately from the path.

@sorenmacbeth
Copy link
Collaborator

I'll take a look. Again, a PR would be awesome :)

@dkincaid
Copy link
Contributor Author

I'm not exactly sure what I did, but both commits for this issue and 30 ended up on a single PR. Someday I'll figure out the proper way to do PR's on Github. Hopefully it's not too much work to tease them apart (if you even need to).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants