Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows ErrorHandlingMiddleware to be disabled #108

Open
2 tasks done
wlclass opened this issue Jan 2, 2023 · 1 comment
Open
2 tasks done

Allows ErrorHandlingMiddleware to be disabled #108

wlclass opened this issue Jan 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wlclass
Copy link

wlclass commented Jan 2, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure a similar issue has not already been created

Description

I use Mockaco. AspNetCore in my asp.net core project,
There is already a middleware defined to handle global exceptions in my project, and there is no way to remove ErrorHandlingMiddleware when I use the UseMockaco() extension method.

Because ErrorHandlingMiddleware ,RequestMatchingMiddleware,ResponseDelayMiddleware,ResponseMockingMiddleware, CallbackMiddleware them access-modifiers is internal,

Can we make these access-modifiers of public so that we can selectively add them?

Proposed solution

Will ErrorHandlingMiddleware RequestMatchingMiddleware ResponseDelayMiddleware ResponseMockingMiddleware CallbackMiddleware changes their access-modifiers to public

Alternatives

Add an option to MockacoOptions to indicate whether ErrorHandlingMiddleware needs to be enabled

Additional context

No response

@wlclass wlclass added the enhancement New feature or request label Jan 2, 2023
@natenho
Copy link
Owner

natenho commented Jan 2, 2023

@wlclass great! would you be interested in implementing this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants