diff --git a/Os/Directory.hpp b/Os/Directory.hpp index 84e3bc745a..f39b782d15 100644 --- a/Os/Directory.hpp +++ b/Os/Directory.hpp @@ -3,7 +3,6 @@ #include #include -#include #include namespace Os { @@ -12,7 +11,9 @@ struct DirectoryHandle {}; class DirectoryInterface { public: - static constexpr FwSizeType FPP_CONFIG_FILENAME_MAX_SIZE = FppConstant_FileNameStringSize::FileNameStringSize; + // REVIEW NOTE: Where is the best place to retrieve that config from? + static constexpr FwSizeType FPP_CONFIG_FILENAME_MAX_SIZE = 256; + typedef enum { OP_OK, //!< Operation was successful DOESNT_EXIST, //!< Directory doesn't exist diff --git a/Os/FileSystem.hpp b/Os/FileSystem.hpp index 92814eabee..107a503c37 100644 --- a/Os/FileSystem.hpp +++ b/Os/FileSystem.hpp @@ -2,7 +2,6 @@ #define _OS_FILESYSTEM_HPP_ #include -#include #include #include #include @@ -15,8 +14,6 @@ struct FileSystemHandle {}; class FileSystemInterface { public: - static constexpr FwSizeType FPP_CONFIG_FILENAME_MAX_SIZE = FppConstant_FileNameStringSize::FileNameStringSize; - typedef enum { OP_OK, //!< Operation was successful ALREADY_EXISTS, //!< File already exists diff --git a/Os/Posix/error.cpp b/Os/Posix/error.cpp index 432352d2a8..837defbc22 100644 --- a/Os/Posix/error.cpp +++ b/Os/Posix/error.cpp @@ -54,7 +54,7 @@ FileSystem::Status errno_to_filesystem_status(PlatformIntType errno_input) { case 0: status = FileSystem::Status::OP_OK; break; - // All fall throughs are intended to fallback on OTHER_ERROR + // All fall through are intended to fallback on OTHER_ERROR case EACCES: status = FileSystem::Status::NO_PERMISSION; break;