-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 1 state machines #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FPP State machine behavior spec
bocchino
reviewed
Aug 31, 2024
compiler/tools/fpp-to-cpp/test/component/ActiveStateMachines_S1.hpp
Outdated
Show resolved
Hide resolved
Fix related bug in code gen Update unit tests
|
bocchino
reviewed
Sep 3, 2024
bocchino
reviewed
Sep 3, 2024
compiler/tools/fpp-to-cpp/test/component/ActiveStateMachines_S1.cpp
Outdated
Show resolved
Hide resolved
bocchino
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
LeStarch
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the Phase 1 of state machines to the FPP language. In phase 1 the state machine behavior is specified outside FPP but the state machine definition names and instance names are specified in FPP and the appropriate support code is generated in the component base class. There are also some incidental cleanup like the key words (ask Rob)