-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made error message clickable #273
Conversation
I like the idea, but why are Python files being added in this PR? It seems that only Location.scala and the unit test reference files should be changed. |
I didn't notice that when I push. I'll remove the python file and I'll proceed with the update of the tests. |
@bocchino the python files have been removed and the unit tests updated, the pull request is ready for review. P.s.: thanks to @JohanBertrand for helping to update the unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for this update.
Change
This pull request I changed the path of the file printed in the error message from
to
Motivation
The new chance make the error message clickable from vs code and maybe for other editor too.
Moreover it follows the changes done in Fprime for unit tests and asserts:
Note
If the Fpp community agree with this change I will update the tests accordingly because this changes broke a lot of tests as for example: