Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made error message clickable #273

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

SMorettini
Copy link
Contributor

@SMorettini SMorettini commented Jul 7, 2023

Change

This pull request I changed the path of the file printed in the error message from

/my_path/folder/folder/my_file.fpp: 61.66

to

/my_path/folder/folder/my_file.fpp:61.66

Motivation

The new chance make the error message clickable from vs code and maybe for other editor too.

Moreover it follows the changes done in Fprime for unit tests and asserts:

Note

If the Fpp community agree with this change I will update the tests accordingly because this changes broke a lot of tests as for example:

--- missing_ports.ref.txt	2023-06-06 13:21:23.924335286 +0000
+++ missing_ports.out.txt	2023-07-07 07:13:09.288195548 +0000
@@ -1,5 +1,5 @@
 fpp-check
-[ local path prefix ]/compiler/tools/fpp-check/test/event/missing_ports.fpp: 1.1
+[ local path prefix ]/compiler/tools/fpp-check/test/event/missing_ports.fpp:1.1
 passive component C {
 ^
 error: component with event specifiers must have event port

@bocchino
Copy link
Collaborator

I like the idea, but why are Python files being added in this PR? It seems that only Location.scala and the unit test reference files should be changed.

@SMorettini
Copy link
Contributor Author

I like the idea, but why are Python files being added in this PR? It seems that only Location.scala and the unit test reference files should be changed.

I didn't notice that when I push. I'll remove the python file and I'll proceed with the update of the tests.

@SMorettini
Copy link
Contributor Author

SMorettini commented Jul 11, 2023

@bocchino the python files have been removed and the unit tests updated, the pull request is ready for review.

P.s.: thanks to @JohanBertrand for helping to update the unit tests

@bocchino bocchino self-requested a review July 13, 2023 16:41
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this update.

@bocchino bocchino merged commit 81d6a1a into nasa:main Jul 13, 2023
@SMorettini SMorettini deleted the Make-error-message-clickable branch July 14, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants