Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ writer for component implementation templates #268

Merged
merged 19 commits into from
Jul 11, 2023

Conversation

tiffany1618
Copy link
Collaborator

@tiffany1618 tiffany1618 commented Jun 27, 2023

Closes #218

  • Add ComponentImplWriter for writing C++ component implementation templates
  • Add template parameter to CppWriterState to indicate whether to generate component base or implementation classes
  • Add support for generating C++ files with arbitrary file extensions
  • Reorganize unit tests for C++ component writer and add unit tests for implementation templates

Changes from Python autocoder:

  • Add handler implementations for internal interfaces
  • Change file extension of template files from .{hpp,cpp}-template to .template.{hpp,cpp}
  • Fix formatting of Doxygen comments

Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we're now very close to doing an FPP release.

I made a few comments. Please take a look at them. We can discuss them tomorrow at the meeting.

Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's just remove the init function in the component template, per the comment from Michael.

Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bocchino bocchino merged commit 1811afc into nasa:main Jul 11, 2023
@tiffany1618 tiffany1618 deleted the component-impl branch July 27, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement C++ component implementation templates
3 participants