-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ writer for component implementation templates #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think we're now very close to doing an FPP release.
I made a few comments. Please take a look at them. We can discuss them tomorrow at the meeting.
compiler/lib/src/main/scala/codegen/CppWriter/CppWriterState.scala
Outdated
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/CppWriter/ComputeCppFiles.scala
Outdated
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/CppWriter/ComponentCppWriter/ComponentImplWriter.scala
Outdated
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/ComputeGeneratedFiles.scala
Outdated
Show resolved
Hide resolved
compiler/lib/src/main/scala/codegen/CppWriter/CppWriterState.scala
Outdated
Show resolved
Hide resolved
It's broken and is breaking CI
compiler/tools/fpp-to-cpp/test/component/impl/ActiveCommands.ref.template.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Let's just remove the init function in the component template, per the comment from Michael.
It works better for pattern matching when cleaning files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes #218
ComponentImplWriter
for writing C++ component implementation templatestemplate
parameter toCppWriterState
to indicate whether to generate component base or implementation classesChanges from Python autocoder:
.{hpp,cpp}-template
to.template.{hpp,cpp}