Remove conditionally-compiled code in TBL #2545
Assignees
Labels
Comments
jphickey
added a commit
to jphickey/cFE
that referenced
this issue
May 17, 2024
Improve the config module to handle platform-specific definitions from the "cfe_platform_cfg.h" file. Specifically this can generate static tables/lists for items that cannot be simply handled via the C preprocessor. Notable examples are the mem pool size lists and the allowable processor/spacecraft IDs in table services.
jphickey
added a commit
to jphickey/cFE
that referenced
this issue
May 21, 2024
Utilize the compile-time generated list feature of the config module to replace hardcoded lists of items in ES, SB, and TBL. In particular this applies to the ES mempool sizes, SB mempool sizes, and the spacecraft and processor ID lists in TBL. Note that the TBL code was not in accordance with coding standards as it was (by default) compiled out via an #if directive, and thus not being tested as it should be. This fixes that, by removing the conditional compile and always testing the code.
jphickey
added a commit
to jphickey/cFE
that referenced
this issue
Oct 1, 2024
Utilize the compile-time generated list feature of the config module to replace hardcoded lists of items in ES, SB, and TBL. In particular this applies to the ES mempool sizes, SB mempool sizes, and the spacecraft and processor ID lists in TBL. Note that the TBL code was not in accordance with coding standards as it was (by default) compiled out via an #if directive, and thus not being tested as it should be. This fixes that, by removing the conditional compile and always testing the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
There are some code chunks that are within
#ifblocks, based on the configuration parametersCFE_PLATFORM_TBL_VALID_SCID_COUNTandCFE_PLATFORM_TBL_VALID_PRID_COUNT.Describe the solution you'd like
Refactor code so it is not conditionally compiled. (limit preprocessor logic usage to data structure initializers, not runtime instructions)
Describe alternatives you've considered
N/A
Additional context
Conditionally-compiled code is not in accordance with current coding standards. Runtime loops of 0 size are OK. The unit test/coverage test must be able to execute the code, which is not possible if it has been compiled out.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: