Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several switch statements in cFE are missing a default and/or break #2478

Open
2 tasks done
thnkslprpt opened this issue Dec 8, 2023 · 0 comments · May be fixed by #2479
Open
2 tasks done

Several switch statements in cFE are missing a default and/or break #2478

thnkslprpt opened this issue Dec 8, 2023 · 0 comments · May be fixed by #2479

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Several switch statements in cFE are missing a default case and/or a terminating break in the default case.

Expected behavior
Relevant coding standards require that all non-empty switch cases (including default) are terminated by an unconditional break.

This is considered defensive coding for future code changes and improves consistency across cFE.

Reporter Info
Avi Weiss   @thnkslprpt

thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Dec 8, 2023
@thnkslprpt thnkslprpt linked a pull request Dec 8, 2023 that will close this issue
2 tasks
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jan 25, 2024
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jan 25, 2024
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Mar 23, 2024
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant