From e294941bd4af0ee758ecd89a7d49c3853b54adcc Mon Sep 17 00:00:00 2001 From: "Gerardo E. Cruz-Ortiz" <59618057+astrogeco@users.noreply.github.com> Date: Fri, 2 Apr 2021 08:56:44 -0400 Subject: [PATCH 1/3] Fix #1277, ZeroCopy typo in ReadMe Fixes mislabeled function in v6.8.0-rc1+dev484 change description --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9dbc32c99..25e349654 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,7 @@ The detailed cFE user's guide can be viewed at Date: Mon, 29 Mar 2021 13:21:22 -0400 Subject: [PATCH 2/3] Fix #1273, remove PspConfig global object The `PspConfig` member is removed from the `GLOBAL_CONFIGDATA` object. Updates the only remaining ref to this object inside the CFE_PSP_VERSION macro to use the API function instead. This also updates the OSAL and CFE version print to _not_ depend on the global object too - OSAL becomes an API call and CFE can just use the macro directly because its the same library (itself) so no linking concern/issue. --- cmake/target/inc/target_config.h | 2 -- cmake/target/src/target_config.c | 1 - modules/es/fsw/src/cfe_es_task.c | 12 ++++++------ 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/cmake/target/inc/target_config.h b/cmake/target/inc/target_config.h index 554b2a2c1..170a38f05 100644 --- a/cmake/target/inc/target_config.h +++ b/cmake/target/inc/target_config.h @@ -32,7 +32,6 @@ #define TARGET_CONFIG_H #include "common_types.h" -#include "cfe_psp_configdata.h" /** * Prototype for the main system entry function implemented in CFE ES @@ -191,7 +190,6 @@ typedef const struct const char *Default_CoreFilename; /**< Default file name for CFE core executable/library */ Target_CfeConfigData *CfeConfig; /**< CFE configuration sub-structure */ - Target_PspConfigData *PspConfig; /**< PSP configuration sub-structure */ CFE_StaticModuleLoadEntry_t *PspModuleList; /**< List of PSP modules (API structures) statically linked into the core EXE */ diff --git a/cmake/target/src/target_config.c b/cmake/target/src/target_config.c index 03f58796d..2995bd73c 100644 --- a/cmake/target/src/target_config.c +++ b/cmake/target/src/target_config.c @@ -174,7 +174,6 @@ Target_ConfigData GLOBAL_CONFIGDATA = { .Default_ModuleExtension = CFE_DEFAULT_MODULE_EXTENSION, .Default_CoreFilename = CFE_DEFAULT_CORE_FILENAME, .CfeConfig = &GLOBAL_CFE_CONFIGDATA, - .PspConfig = &GLOBAL_PSP_CONFIGDATA, .PspModuleList = CFE_PSP_MODULE_LIST, .BuildEnvironment = CFE_BUILD_ENV_TABLE, .ModuleVersionList = CFE_MODULE_VERSION_TABLE, diff --git a/modules/es/fsw/src/cfe_es_task.c b/modules/es/fsw/src/cfe_es_task.c index 3afd7d511..5c2f28301 100644 --- a/modules/es/fsw/src/cfe_es_task.c +++ b/modules/es/fsw/src/cfe_es_task.c @@ -465,10 +465,10 @@ int32 CFE_ES_TaskInit(void) return (Status); } - Status = CFE_EVS_SendEvent(CFE_ES_INITSTATS_INF_EID, CFE_EVS_EventType_INFORMATION, - "cFS Versions: cfe %s, osal %s, psp %s. cFE chksm %d", GLOBAL_CONFIGDATA.CfeVersion, - GLOBAL_CONFIGDATA.OsalVersion, CFE_PSP_VERSION, - (int)CFE_ES_Global.TaskData.HkPacket.Payload.CFECoreChecksum); + Status = + CFE_EVS_SendEvent(CFE_ES_INITSTATS_INF_EID, CFE_EVS_EventType_INFORMATION, + "cFS Versions: cfe %s, osal %s, psp %s. cFE chksm %d", CFE_SRC_VERSION, OS_GetVersionString(), + CFE_PSP_GetVersionString(), (int)CFE_ES_Global.TaskData.HkPacket.Payload.CFECoreChecksum); if (Status != CFE_SUCCESS) { @@ -847,8 +847,8 @@ int32 CFE_ES_NoopCmd(const CFE_ES_NoopCmd_t *Cmd) CFE_ES_Global.TaskData.CommandCounter++; CFE_EVS_SendEvent(CFE_ES_NOOP_INF_EID, CFE_EVS_EventType_INFORMATION, - "No-op command:\n cFS Versions: cfe %s, osal %s, psp %s", GLOBAL_CONFIGDATA.CfeVersion, - GLOBAL_CONFIGDATA.OsalVersion, CFE_PSP_VERSION); + "No-op command:\n cFS Versions: cfe %s, osal %s, psp %s", CFE_SRC_VERSION, OS_GetVersionString(), + CFE_PSP_GetVersionString()); return CFE_SUCCESS; } /* End of CFE_ES_NoopCmd() */ From 8a36253788dbe7ed05dc3a5b0cda99dc07d175c4 Mon Sep 17 00:00:00 2001 From: "Gerardo E. Cruz-Ortiz" <59618057+astrogeco@users.noreply.github.com> Date: Fri, 2 Apr 2021 18:19:10 -0400 Subject: [PATCH 3/3] IC:2021-04-02, Bump to v6.8.0-rc1+dev490 --- README.md | 6 ++++++ modules/core_api/fsw/inc/cfe_version.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 25e349654..594dcd016 100644 --- a/README.md +++ b/README.md @@ -10,6 +10,12 @@ The detailed cFE user's guide can be viewed at and + ### Development Build: v6.8.0-rc1+dev484 - Removes cases in `cfe_es_apps.c` and `cfe_tbl_internal.c` that could never hit the alternate condition since the condition was already checked diff --git a/modules/core_api/fsw/inc/cfe_version.h b/modules/core_api/fsw/inc/cfe_version.h index 7c7a7a597..39980ed99 100644 --- a/modules/core_api/fsw/inc/cfe_version.h +++ b/modules/core_api/fsw/inc/cfe_version.h @@ -28,7 +28,7 @@ #define CFE_VERSION_H /* Development Build Macro Definitions */ -#define CFE_BUILD_NUMBER 484 /*!< Development Build: Number of commits since baseline */ +#define CFE_BUILD_NUMBER 490 /*!< Development Build: Number of commits since baseline */ #define CFE_BUILD_BASELINE \ "v6.8.0-rc1" /*!< Development Build: git tag that is the base for the current development \ */