Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert changes in validate script that broke versioning #178

Closed
wants to merge 2 commits into from

Conversation

dakota002
Copy link
Contributor

This removes the id checking. The checks in place here broke versioning.

The validation script would run on the commit mid-version command, before the tag had been applied to a commit, so you would see errors like:

(not finding the correct ref)

error: gcn\notices\glowbug\Alert.schema.json: expected value of $id to be https://gcn.nasa.gov/schema/main/gcn\notices\glowbug\Alert.schema.json, but found https://gcn.nasa.gov/schema/v4.1.1/gcn/notices/glowbug/Alert.schema.json

or

(forward vs backslash on Windows)

error: gcn\notices\core\Event.schema.json: expected value of $id to be https://gcn.nasa.gov/schema/main/gcn\notices\core\Event.schema.json, but found https://gcn.nasa.gov/schema/main/gcn/notices/core/Event.schema.json

@dakota002 dakota002 requested a review from lpsinger July 22, 2024 21:02
@lpsinger
Copy link
Member

Please don't revert this. I'll fix it tomorrow.

@dakota002
Copy link
Contributor Author

Closing so as not to revert completely

@dakota002 dakota002 closed this Jul 22, 2024
@dakota002 dakota002 deleted the NewTests branch October 17, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants