{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":30645800,"defaultBranch":"master","name":"namecoin-core","ownerLogin":"namecoin","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2015-02-11T12:02:31.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1068524?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725365817.0","currentOid":""},"activityList":{"items":[{"before":"a5fa90706addb3ebc4325b139cfebcf9d7ac3045","after":"0c4ff18ee9ec91b424ad26d2643e42566aa45e40","ref":"refs/heads/bitcoin","pushedAt":"2024-09-16T11:16:57.000Z","pushType":"push","commitsCount":106,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30896: kernel: Move background load thread to node context\n\nbc7900f33db3d01fb93dfee7981c01ea495cd42e kernel: Move background load thread to node context (TheCharlatan)\n\nPull request description:\n\n The thread handle is never used by the ChainstateManager, so move it out and into the node context. Users of the kernel library now no longer have to manually join the thread when destructing the ChainstateManager.\n\nACKs for top commit:\n maflcko:\n ACK bc7900f33db3d01fb93dfee7981c01ea495cd42e 🔄\n achow101:\n ACK bc7900f33db3d01fb93dfee7981c01ea495cd42e\n ryanofsky:\n Code review ACK bc7900f33db3d01fb93dfee7981c01ea495cd42e. Nice cleanup\n jonatack:\n Light ACK bc7900f33db3d01fb93dfee7981c01ea495cd42e\n stickies-v:\n ACK bc7900f33db3d01fb93dfee7981c01ea495cd42e\n\nTree-SHA512: add9c4823731324e3db50f95e023e99d55db7cc75c69083ae7c9c2157e5540968caa6cf10674aa4901f91366b02ebb1ff18bb977fec0a46431e2196448958b9d","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30896: kernel: Move background load thread to n…"}},{"before":"35abba5537e4253b24df093a99bc32fc00db62c9","after":"2f854292768cf0b81315b41ae67e83c3ec2a5ccd","ref":"refs/heads/auxpow","pushedAt":"2024-09-16T11:16:57.000Z","pushType":"push","commitsCount":107,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'bitcoin' into auxpow","shortMessageHtmlLink":"Merge branch 'bitcoin' into auxpow"}},{"before":"c310c0e8c68a17b192b3a0ade01665fc3824077d","after":"fafc5b4155520b0ad741e351722b32f3f7c9d237","ref":"refs/heads/master","pushedAt":"2024-09-16T11:16:57.000Z","pushType":"push","commitsCount":108,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow'","shortMessageHtmlLink":"Merge branch 'auxpow'"}},{"before":"1121f95fb452dc346d3dd692660b5faaa8684c30","after":"7b57d7301a46df3d498729db64495a266032dd28","ref":"refs/heads/28.x","pushedAt":"2024-09-09T12:01:09.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'bitcoin-28.x' into 28.x","shortMessageHtmlLink":"Merge branch 'bitcoin-28.x' into 28.x"}},{"before":"5f68cd78f7a591eaba2bf02c41b464271f125f69","after":"35abba5537e4253b24df093a99bc32fc00db62c9","ref":"refs/heads/auxpow","pushedAt":"2024-09-09T12:00:38.000Z","pushType":"push","commitsCount":120,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'bitcoin' into auxpow","shortMessageHtmlLink":"Merge branch 'bitcoin' into auxpow"}},{"before":"5abb9b1af49be9024f95fa2f777285c531785d85","after":"a5fa90706addb3ebc4325b139cfebcf9d7ac3045","ref":"refs/heads/bitcoin","pushedAt":"2024-09-09T12:00:38.000Z","pushType":"push","commitsCount":119,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30834: test: Work around boost compilation error\n\nfa9d7d5d205ada8915cbbc29599ab8e7bf1fffe0 test: Work around boost compilation error (MarcoFalke)\nfa3ecdf778bcde7713004ff8bb86d3fdfc916969 Revert \"build: work around issue with Boost <= 1.80 and Clang >= 18\" (MarcoFalke)\n\nPull request description:\n\n There seems to be an issue compiling the `chainstatemanager_rebalance_caches` test case with some specific versions of Boost in combination with some specific versions of Clang. For example, Boost 1.74 may fail in combination with Clang 18. [1]\n\n The error stems from a mixed-type closeness comparison. Given that the comparison is using floating point, and isn't meant to be exact, work around the compile error by ensuring both sides of the comparison are using the same type (`double`).\n\n This also allows to drop a previous workaround.\n\n [1] Error:\n\n ```\n In file included from /usr/include/boost/mpl/integral_c.hpp:32:\n /usr/include/boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'udt_builtin_mixture_enum' [-Wenum-constexpr-conversion]\n 73 | typedef AUX_WRAPPER_INST( BOOST_MPL_AUX_STATIC_CAST(AUX_WRAPPER_VALUE_TYPE, (value - 1)) ) prior;\n | ^\n /usr/include/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'\n 24 | # define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast(expr)\n | ^\n In file included from ../../../src/test/validation_chainstatemanager_tests.cpp:8:\n In file included from ../../../src/node/chainstatemanager_args.h:9:\n In file included from ../../../src/validation.h:28:\n In file included from ../../../src/txmempool.h:26:\n In file included from /usr/include/boost/multi_index/hashed_index.hpp:38:\n In file included from /usr/include/boost/multi_index/detail/node_handle.hpp:22:\n In file included from /usr/include/boost/multi_index_container_fwd.hpp:18:\n In file included from /usr/include/boost/multi_index/indexed_by.hpp:17:\n In file included from /usr/include/boost/mpl/vector.hpp:36:\n In file included from /usr/include/boost/mpl/vector/vector20.hpp:18:\n In file included from /usr/include/boost/mpl/vector/vector10.hpp:18:\n In file included from /usr/include/boost/mpl/vector/vector0.hpp:24:\n In file included from /usr/include/boost/mpl/vector/aux_/clear.hpp:18:\n In file included from /usr/include/boost/mpl/vector/aux_/vector0.hpp:22:\n In file included from /usr/include/boost/mpl/vector/aux_/iterator.hpp:19:\n In file included from /usr/include/boost/mpl/plus.hpp:19:\n In file included from /usr/include/boost/mpl/aux_/arithmetic_op.hpp:17:\n In file included from /usr/include/boost/mpl/integral_c.hpp:32:\n /usr/include/boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'int_float_mixture_enum' [-Wenum-constexpr-conversion]\n /usr/include/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'\n 24 | # define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast(expr)\n | ^\n 2 errors generated.\n\nACKs for top commit:\n hebasto:\n ACK fa9d7d5d205ada8915cbbc29599ab8e7bf1fffe0.\n fanquake:\n ACK fa9d7d5d205ada8915cbbc29599ab8e7bf1fffe0\n\nTree-SHA512: 4964b23162f2351c7d3cf7e9efa7860d62f3b6717c3cc5be967d286f1ddb3539c2637247c79aa83123d36ff111ba77df22be2a25487ddd94dc1321d5e751dc70","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30834: test: Work around boost compilation error"}},{"before":"1805511656649c89948952b492e108a865c059aa","after":"c310c0e8c68a17b192b3a0ade01665fc3824077d","ref":"refs/heads/master","pushedAt":"2024-09-09T12:00:38.000Z","pushType":"push","commitsCount":121,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow'","shortMessageHtmlLink":"Merge branch 'auxpow'"}},{"before":"b35a94a05990d1192f101f4d44e1f9a6f2a51687","after":"1805511656649c89948952b492e108a865c059aa","ref":"refs/heads/master","pushedAt":"2024-09-05T18:31:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Update CMake build system for Namecoin.\n\nThis updates the new CMake-based build system for Namecoin: Rebranding\nthe key outputs (that are installed, not renaming internal libraries\nand things like that), and adding the Namecoin-specific files.","shortMessageHtmlLink":"Update CMake build system for Namecoin."}},{"before":"1248d0da22794f76ea805364f82558aaad50aabf","after":"5abb9b1af49be9024f95fa2f777285c531785d85","ref":"refs/heads/bitcoin","pushedAt":"2024-09-05T17:35:41.000Z","pushType":"push","commitsCount":173,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30763: doc: update Fedora build instructions for cmake\n\n877c55a68b65b30f226f4747829bc7336329e295 doc: update fedora build instructions for cmake (Marnix)\n\nPull request description:\n\n Update Fedora build instructions for cmake:\n\n - update the Fedora build requirements\n - remove old configure instruction\n\n This was forgotten to update\n\nACKs for top commit:\n davidgumberg:\n ACK https://github.com/bitcoin/bitcoin/commit/877c55a68b65b30f226f4747829bc7336329e295\n l0rinc:\n utACK 877c55a68b65b30f226f4747829bc7336329e295\n hebasto:\n ACK 877c55a68b65b30f226f4747829bc7336329e295.\n pablomartin4btc:\n ACK 877c55a68b65b30f226f4747829bc7336329e295\n tdb3:\n ACK 877c55a68b65b30f226f4747829bc7336329e295\n\nTree-SHA512: 53fbd4bef96d2aeef753f26359eab53023a154fbcc75952aecd15e8805cc24ceb8ebdc6d8746416720b5655ed694299b3381a2e4d621ebd522fb09d145c48665","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30763: doc: update Fedora build instructions fo…"}},{"before":"7f73e2350118f6cea6cbc977bfbe155f911fd510","after":"5f68cd78f7a591eaba2bf02c41b464271f125f69","ref":"refs/heads/auxpow","pushedAt":"2024-09-05T17:35:41.000Z","pushType":"push","commitsCount":174,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'bitcoin' into auxpow\n\nUpdated new CMake-based build system to include the auxpow-specific\nfiles and tests.","shortMessageHtmlLink":"Merge branch 'bitcoin' into auxpow"}},{"before":"fef3f4f67745bda5b4d12baa16389f911df56d05","after":"b35a94a05990d1192f101f4d44e1f9a6f2a51687","ref":"refs/heads/master","pushedAt":"2024-09-05T17:35:41.000Z","pushType":"push","commitsCount":175,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow'\n\nThis is still using the autotools build system. It will be changed\nto CMake (with adaptions necessary for Namecoin and rebranding) in\na follow-up change.","shortMessageHtmlLink":"Merge branch 'auxpow'"}},{"before":"fef3f4f67745bda5b4d12baa16389f911df56d05","after":"1121f95fb452dc346d3dd692660b5faaa8684c30","ref":"refs/heads/28.x","pushedAt":"2024-09-03T17:26:11.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow-28.x' into 28.x","shortMessageHtmlLink":"Merge branch 'auxpow-28.x' into 28.x"}},{"before":null,"after":"fef3f4f67745bda5b4d12baa16389f911df56d05","ref":"refs/heads/28.x","pushedAt":"2024-09-03T12:16:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow'","shortMessageHtmlLink":"Merge branch 'auxpow'"}},{"before":"6d546336e800f7b8990fececab6bc08413f28690","after":"1248d0da22794f76ea805364f82558aaad50aabf","ref":"refs/heads/bitcoin","pushedAt":"2024-09-03T11:25:53.000Z","pushType":"push","commitsCount":38,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30719: Pre-28.x branch off version bump and doc updates\n\n1bf9b706583572b1211762ec6ee5368bb8a2f2cd docs: Add 379 and 387 to bips.md (Ava Chow)\n35ef34eab7b36e3c53ed438d74a9b783cbcaec27 docs: Remove release 28.0 release notes fragments (Ava Chow)\nf5cf43bb912e817cbddd870c6c2f6c615840f5fd build: Bump to 28.99 (Ava Chow)\n\nPull request description:\n\n * Bump to 28.99 in preparation for the 28.x branching\n * Remove current release note fragments. They've been moved to [draft release notes]((https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft).) in the wiki.\n * Updated bips.md with missing BIPs that were implemented a while ago.\n\nACKs for top commit:\n maflcko:\n lgtm ACK 1bf9b706583572b1211762ec6ee5368bb8a2f2cd\n tdb3:\n re ACK 1bf9b706583572b1211762ec6ee5368bb8a2f2cd\n\nTree-SHA512: 9d5b05330268bb233369d78f06011dbdcdcb87770c499ae743ac4833735ba657b6611ff1e332c9d4added854b694c5a3a961d911247303f7ddaaaa72149d5574","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30719: Pre-28.x branch off version bump and doc…"}},{"before":"08efd59b6dc7fc3d1eba40671967d44c6f21828d","after":"7f73e2350118f6cea6cbc977bfbe155f911fd510","ref":"refs/heads/auxpow","pushedAt":"2024-09-03T11:25:53.000Z","pushType":"push","commitsCount":39,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'bitcoin' into auxpow","shortMessageHtmlLink":"Merge branch 'bitcoin' into auxpow"}},{"before":"d03656c1186d2cadfa424964d06f666e7ce5f313","after":"fef3f4f67745bda5b4d12baa16389f911df56d05","ref":"refs/heads/master","pushedAt":"2024-09-03T11:25:53.000Z","pushType":"push","commitsCount":40,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow'","shortMessageHtmlLink":"Merge branch 'auxpow'"}},{"before":"4698327e1202753bea7670161142697ecd2f4cb6","after":"d03656c1186d2cadfa424964d06f666e7ce5f313","ref":"refs/heads/master","pushedAt":"2024-08-28T18:33:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Support OBJ_USER_KEYS inside other objects.\n\nImplement support for OBJ_USER_KEYS RPCArg's inside other objects, as that\nis required in Namecoin for the \"sendCoins\" option.\n\nFixes https://github.com/namecoin/namecoin-core/issues/548.","shortMessageHtmlLink":"Support OBJ_USER_KEYS inside other objects."}},{"before":"8b77b06cfab69adf5229a55cd331be0045f072a2","after":"08efd59b6dc7fc3d1eba40671967d44c6f21828d","ref":"refs/heads/auxpow","pushedAt":"2024-08-28T17:40:43.000Z","pushType":"push","commitsCount":30,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'bitcoin' into auxpow","shortMessageHtmlLink":"Merge branch 'bitcoin' into auxpow"}},{"before":"3dc70528e53c596c91732a89658c1e179a998f91","after":"4698327e1202753bea7670161142697ecd2f4cb6","ref":"refs/heads/master","pushedAt":"2024-08-28T17:40:43.000Z","pushType":"push","commitsCount":31,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow'","shortMessageHtmlLink":"Merge branch 'auxpow'"}},{"before":"ee367170cb2acf82b6ff8e0ccdbc1cce09730662","after":"6d546336e800f7b8990fececab6bc08413f28690","ref":"refs/heads/bitcoin","pushedAt":"2024-08-28T17:40:43.000Z","pushType":"push","commitsCount":29,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30651: fuzz: remove repeated word in note\n\n3f05a1068d10ffe0f2859cd20c5fc9bc8efa1c70 remove repeated word in note (sunerok)\n\nPull request description:\n\n Fix typo.\n\nACKs for top commit:\n maflcko:\n ACK 3f05a1068d10ffe0f2859cd20c5fc9bc8efa1c70\n danielabrozzoni:\n ACK 3f05a1068d10ffe0f2859cd20c5fc9bc8efa1c70\n\nTree-SHA512: 709d96ed18608c0ea788b4f0696abad79ab1b81c4f266487d16bbe4cfca5b99b8f7f9a58f830866db9695aa3aebcc6442098b1533d85507729af99709a53d26a","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30651: fuzz: remove repeated word in note"}},{"before":"ffc5b236a2e1e7c1f447e45131e44f1d6bc165bc","after":"0d13449295f88cb079dc7d3d5fdad7b88edc54b9","ref":"refs/heads/27.x","pushedAt":"2024-08-26T17:53:03.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow-27.x' into 27.x","shortMessageHtmlLink":"Merge branch 'auxpow-27.x' into 27.x"}},{"before":"ec6926c4a8d6402acba7acb1245edc95432a5738","after":"3dc70528e53c596c91732a89658c1e179a998f91","ref":"refs/heads/master","pushedAt":"2024-08-21T17:42:17.000Z","pushType":"push","commitsCount":70,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow'","shortMessageHtmlLink":"Merge branch 'auxpow'"}},{"before":"29035a31b4a6b77aec8166e08f578a6af38c8e57","after":"8b77b06cfab69adf5229a55cd331be0045f072a2","ref":"refs/heads/auxpow","pushedAt":"2024-08-21T17:42:17.000Z","pushType":"push","commitsCount":69,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'bitcoin' into auxpow","shortMessageHtmlLink":"Merge branch 'bitcoin' into auxpow"}},{"before":"c2d15d993ef06d97d4c117012bda6efa3dcbac45","after":"ee367170cb2acf82b6ff8e0ccdbc1cce09730662","ref":"refs/heads/bitcoin","pushedAt":"2024-08-21T17:42:17.000Z","pushType":"push","commitsCount":68,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30621: wallet: fix blank legacy detection\n\n6ed424f2db609f9f39ec1d1da2077c7616f3a0c2 wallet: fix, detect blank legacy wallets in IsLegacy (furszy)\n\nPull request description:\n\n Blank legacy wallets do not have active SPKM. They can only be\n detected by checking the descriptors' flag or the db format.\n\n This enables the migration of blank legacy wallets in the GUI.\n\n To test this:\n 1) Create a blank legacy wallet.\n 2) Try to migrate it using the GUI's toolbar \"Migrate Wallet\" button.\n -> In master: The button will be disabled because `CWallet::IsLegacy()` returns false for blank legacy wallet.\n -> In this PR: the button will be enabled, allowing the migration of legacy wallets.\n\nACKs for top commit:\n achow101:\n ACK 6ed424f2db609f9f39ec1d1da2077c7616f3a0c2\n tdb3:\n ACK 6ed424f2db609f9f39ec1d1da2077c7616f3a0c2\n glozow:\n ACK 6ed424f2db609f9f39ec1d1da2077c7616f3a0c2\n\nTree-SHA512: c06c4c4c2e546ccb033287b9aa3aee4ca36b47aeb2fac6fbed5de774b65caef9c818fc8dfdaac6ce78839b2d5d642a5632a5b44c5e889ea169ced80ed50501a7","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30621: wallet: fix blank legacy detection"}},{"before":"eebb7ab52e11079b6c831fafbfb51d149667fb92","after":"ec6926c4a8d6402acba7acb1245edc95432a5738","ref":"refs/heads/master","pushedAt":"2024-08-17T18:11:57.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge namecoin/namecoin-core#544: Use internal endian conversion functions\n\n44475726ecd87c370a203cf2fcaebf24e9efe583 Namecoin: use internal endian conversion functions (Jeremy Rand)\n8e3e46cdb1436e0785e167aeec773c26f8fe5528 Namecoin: delete superfluous whitespace (Jeremy Rand)\n\nPull request description:\n\n Upstream Bitcoin Core refactored their endian conversion in 86b7f28d6c507155a9d3a15487ee883989b88943; make Namecoin follow suit.\n\n Fixes a Guix build fail for Windows/x86_64 target.\n\nTop commit has no ACKs.\n\nTree-SHA512: 6761b4b0fc900684193de5d4a506f5dfdf6cc20931ca37d4831265cb660fa06c72e58ef5e65e81a4b8ab23cfb94f2ddeb16893945b6374d856e06fd1faec3b46","shortMessageHtmlLink":"Merge #544: Use internal endian conversion functions"}},{"before":"b3b7c95762b4bd80ec809bdcdf5a90ae4602f898","after":"eebb7ab52e11079b6c831fafbfb51d149667fb92","ref":"refs/heads/master","pushedAt":"2024-08-17T18:09:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge namecoin/namecoin-core#541: Rebrand `namecoin.conf` references\n\nc50f25ebe67368ba591e3333c4ac556e97ad4783 Namecoin: Rebrand namecoin.conf references (Jeremy Rand)\n\nPull request description:\n\n `namecoin.conf`'s filename was rebranded already, but references to it still used `bitcoin.conf`. This caused a Guix build fail for Linux targets, and probably also Windows targets.\n\nTop commit has no ACKs.\n\nTree-SHA512: f0c095903a6f8102276aa10af7b331f0bb67dc7e23ecd4ef18f7564b0b50f13005020787c534889e11505b8c3f27f4b07cf8b7743e2c14378d9313cad4f4fc23","shortMessageHtmlLink":"Merge #541: Rebrand namecoin.conf references"}},{"before":"ee40dedbb25871cfe40518a8fc30026ef7bff147","after":"29035a31b4a6b77aec8166e08f578a6af38c8e57","ref":"refs/heads/auxpow","pushedAt":"2024-08-12T18:43:29.000Z","pushType":"push","commitsCount":111,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'bitcoin' into auxpow","shortMessageHtmlLink":"Merge branch 'bitcoin' into auxpow"}},{"before":"c8286dcb85e4760d22478acaf0514b2f41d64f54","after":"b3b7c95762b4bd80ec809bdcdf5a90ae4602f898","ref":"refs/heads/master","pushedAt":"2024-08-12T18:43:29.000Z","pushType":"push","commitsCount":112,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge branch 'auxpow'","shortMessageHtmlLink":"Merge branch 'auxpow'"}},{"before":"1a7d20509f46f0cd38302da78dba9a0c9bb24226","after":"c2d15d993ef06d97d4c117012bda6efa3dcbac45","ref":"refs/heads/bitcoin","pushedAt":"2024-08-12T18:43:29.000Z","pushType":"push","commitsCount":110,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29519: p2p: For assumeutxo, download snapshot chain before background chain\n\n49d569cb1fdd62a9da8dff51dccaf4680fe3d0eb p2p: For assumeutxo, download snapshot chain before background chain (Martin Zumsande)\n7a885518d57c6eb818ebef5fd04a575f324ee8b2 p2p: Restrict downloading of blocks for snapshot chain (Martin Zumsande)\n\nPull request description:\n\n After loading a snapshot, `pindexLastCommonBlock` is usually already set to some block for existing peers. That means we'd continue syncing the background chain from those peers instead of prioritising the snapshot chain, which defeats the purpose of doing assumeutxo in the first place. Only existing peers are affected by this bug.\n\nACKs for top commit:\n fjahr:\n re-ACK 49d569cb1fdd62a9da8dff51dccaf4680fe3d0eb\n achow101:\n ACK 49d569cb1fdd62a9da8dff51dccaf4680fe3d0eb\n Sjors:\n tACK 49d569cb1fdd62a9da8dff51dccaf4680fe3d0eb\n\nTree-SHA512: 0eaebe1c29a8510d5ced57e14c09b128ccb34b491692815291df68bf12e2a15b52b1e7bf8d9f34808904e7f7bc20f70b0ad0f7e14df93bbdf456bd12cc02a5d2","shortMessageHtmlLink":"Merge bitcoin/bitcoin#29519: p2p: For assumeutxo, download snapshot c…"}},{"before":"38c30a4b50ca0ceee0c64fe5ba9b95fe72d3ef48","after":"1a7d20509f46f0cd38302da78dba9a0c9bb24226","ref":"refs/heads/bitcoin","pushedAt":"2024-08-05T11:46:39.000Z","pushType":"push","commitsCount":77,"pusher":{"login":"domob1812","name":"Daniel Kraft","path":"/domob1812","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4943644?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30526: doc: Correct uint256 hex string endianness\n\n73e3fa10b4dd63b7767d6b6f270df66971067341 doc + test: Correct uint256 hex string endianness (Hodlinator)\n\nPull request description:\n\n This PR is a follow-up to #30436.\n\n Only changes test-code and modifies/adds comments.\n\n Byte order of hex string representation was wrongfully documented as little-endian, but are in fact closer to \"big-endian\" (endianness is a memory-order concept rather than a numeric concept). `[arith_]uint256` both store their data in arrays with little-endian byte order (`arith_uint256` has host byte order within each `uint32_t` element).\n\n **uint256_tests.cpp** - Avoid using variable from the left side of the condition in the right side. Credits to @maflcko: https://github.com/bitcoin/bitcoin/pull/30436#discussion_r1688273553\n\n **setup_common.cpp** - Skip needless ArithToUint256-conversion. Credits to @stickies-v: https://github.com/bitcoin/bitcoin/pull/30436#discussion_r1688621638\n\n ---\n\n
\n \n\n ## Logical reasoning for endianness\n\n \n\n 1. Comparing an `arith_uint256` (`base_uint<256>`) to a `uint64_t` compares the beginning of the array, and verifies the remaining elements are zero.\n ```C++\n template \n bool base_uint::EqualTo(uint64_t b) const\n {\n for (int i = WIDTH - 1; i >= 2; i--) {\n if (pn[i])\n return false;\n }\n if (pn[1] != (b >> 32))\n return false;\n if (pn[0] != (b & 0xfffffffful))\n return false;\n return true;\n }\n ```\n ...that is consistent with little endian ordering of the array.\n\n 2. They have the same endianness (but `arith_*` has host-ordering of each `uint32_t` element):\n ```C++\n arith_uint256 UintToArith256(const uint256 &a)\n {\n arith_uint256 b;\n for(int x=0; x uint256 means strings are actually closer to big-endian, see the end of `base_blob::SetHexDeprecated`:\n ```C++\n unsigned char* p1 = m_data.data();\n unsigned char* pend = p1 + WIDTH;\n while (digits > 0 && p1 < pend) {\n *p1 = ::HexDigit(trimmed[--digits]);\n if (digits > 0) {\n *p1 |= ((unsigned char)::HexDigit(trimmed[--digits]) << 4);\n p1++;\n }\n }\n ```\n Same reversal here:\n ```C++\n template \n std::string base_blob::GetHex() const\n {\n uint8_t m_data_rev[WIDTH];\n for (int i = 0; i < WIDTH; ++i) {\n m_data_rev[i] = m_data[WIDTH - 1 - i];\n }\n return HexStr(m_data_rev);\n }\n ```\n It now makes sense to me that `SetHexDeprecated`, upon receiving a shorter hex string that requires zero-padding, would pad as if the missing hex chars where towards the end of the little-endian byte array, as they are the most significant bytes. \"Big-endian\" string representation is also consistent with the case where `SetHexDeprecated` receives too many hex digits and discards the leftmost ones, as a form of integer narrowing takes place.\n\n ### How I got it wrong in #30436\n\n Previously I used the less than (`<`) comparison to prove endianness, but for `uint256` it uses `memcmp` and thereby gives priority to the *lower* bytes at the beginning of the array.\n ```C++\n constexpr int Compare(const base_blob& other) const { return std::memcmp(m_data.data(), other.m_data.data(), WIDTH); }\n ```\n\n `arith_uint256` is different in that it begins by comparing the bytes from the end, as it is using little endian representation, where the bytes toward the end are more significant.\n ```C++\n template \n int base_uint::CompareTo(const base_uint& b) const\n {\n for (int i = WIDTH - 1; i >= 0; i--) {\n if (pn[i] < b.pn[i])\n return -1;\n if (pn[i] > b.pn[i])\n return 1;\n }\n return 0;\n }\n ```\n (The commit documents that `base_blob::Compare()` is doing lexicographic ordering unlike the `arith_*`-variant which is doing numeric ordering).\n\n
\n\nACKs for top commit:\n paplorinc:\n ACK 73e3fa10b4dd63b7767d6b6f270df66971067341\n ryanofsky:\n Code review ACK 73e3fa10b4dd63b7767d6b6f270df66971067341\n\nTree-SHA512: 121630c37ab01aa7f7097f10322ab37da3cbc0696a6bbdbf2bbd6db180dc5938c7ed91003aaa2df7cf4a4106f973f5118ba541b5e077cf3588aa641bbd528f4e","shortMessageHtmlLink":"Merge bitcoin/bitcoin#30526: doc: Correct uint256 hex string endianness"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEt1SQWwA","startCursor":null,"endCursor":null}},"title":"Activity · namecoin/namecoin-core"}