Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graph for vulnerabilities over time and daily imports #7

Merged
merged 99 commits into from
Feb 13, 2024
Merged

Add graph for vulnerabilities over time and daily imports #7

merged 99 commits into from
Feb 13, 2024

Conversation

rbjornstad
Copy link
Contributor

@rbjornstad rbjornstad commented Feb 12, 2024 •
edited by ybelMekk
Loading

An initial import will run on every restart of fasit.

Either from a const date set to first date of known data in dependency track, or last data in db.

ybelMekk and others added 30 commits February 1, 2024 10:30
@ybelMekk
feat(dependencytrack): calc vuln like dptrack
efc8567 
* add tests
@rbjornstad @ybelMekk
Add vulnerability-related database tables
9a475c4 
Co-authored-by: ybelMekk <[email protected]>
@ybelMekk @rbjornstad
WIP
5d6de0b 
Co-authored-by: Roger Bjørnstad <[email protected]>
@ybelMekk @rbjornstad
fix: values
c50532c 
Co-authored-by: Roger Bjørnstad <[email protected]>
@ybelMekk @rbjornstad
uodate vulnerability scheme
8fb5648 
Co-authored-by: Roger Bjørnstad <[email protected]>
@ybelMekk @rbjornstad
add tests
9f675f0 
Co-authored-by: Roger Bjørnstad <[email protected]>
@ybelMekk
Merge remote-tracking branch 'origin/rm_reconciler_state' into vuln_c…
ed1b434 
…ount

# Conflicts:
#	go.mod
#	go.sum
#	internal/database/gensql/mock_querier.go
#	internal/database/gensql/querier.go
#	pkg/protoapi/teams_grpc.pb.go
#	pkg/protoapi/users_grpc.pb.go
@kimtore
Use application status conditions to render user-friendly error messa…
5ce22ae 
…ges (#24)
@ybelMekk @rbjornstad
update(vulnerability): add tests
f103e35 
* update dp client
* generate mocks
* add mocks and for tests

Co-authored-by: Roger Bjørnstad <[email protected]>
@rbjornstad
Add vulnerabilityMetrics field to Team type
a9e44ea
@rbjornstad
Add VulnerabilityMetrics resolver to teamResolver
a706adb
@rbjornstad
Refactor resolver types in app and users packages
78e1022
@rbjornstad
Add .graphqlrc.yaml file with project configuration
a505fda
@rbjornstad
Add date range filter to vulnerabilityMetrics
696a0da
@rbjornstad
Update vulnerability metrics function signature
0fab53b
@rbjornstad @ybelMekk
Update project ID type in VulnerabilityMetrics
0eddf79 
Co-authored-by: ybelMekk <[email protected]>
@ybelMekk @rbjornstad
update(vulnerability): update db
264ca6d 
* fic dptrack fake client

Co-authored-by: Roger Bjørnstad <[email protected]>
@rbjornstad @ybelMekk
Refactor resolver types in app, github_repo, and users
24c5731 
Co-authored-by: ybelMekk <[email protected]>
@rbjornstad @ybelMekk
Update vulnerability SQL queries and vulnerability updater
4781acc 
Co-authored-by: ybelMekk <[email protected]>
@kimtore
Merge remote-tracking branch 'origin/rm_reconciler_state' into app_co…
e05dd90 
…nditions
@rbjornstad
Update vulnerabilityMetrics return type to non-null
29f3217
@ybelMekk @rbjornstad
add(main): setup_local vulns for devteam
8790195 
Co-authored-by: Roger Bjørnstad <[email protected]>
@kimtore
Merge remote-tracking branch 'origin/rm_reconciler_state' into app_co…
19ba249 
…nditions
@kimtore
Revert "Upgrade to Go 1.22"
bacb71d 
This reverts commit 6050729.
@kimtore
make pubsub requirement optional for setup-local
4066455
@kimtore
make pubsub requirement optional for setup-local
b63684a
@kimtore
Merge remote-tracking branch 'origin/rm_reconciler_state' into app_co…
e72c3b9 
…nditions
@ybelMekk @rbjornstad
add(main): vuln config
1a6332c 
Co-authored-by: Roger Bjørnstad <[email protected]>
@rbjornstad
Merge branch 'app_conditions' into vuln_count
f26d8f0
@rbjornstad
Revert "Merge branch 'app_conditions' into vuln_count"
dc96109 
Co-authored-by: ybelMekk <[email protected]>

This reverts commit f26d8f0, reversing
changes made to 1a6332c.
ybelMekk and others added 11 commits February 12, 2024 11:48
@rbjornstad rbjornstad marked this pull request as ready for review February 12, 2024 13:21
thokra-nav
thokra-nav requested changes Feb 12, 2024
View reviewed changes
internal/cmd/api/config.go Outdated Show resolved Hide resolved
internal/cmd/api/vulnerability_metrics_updater.go Outdated Show resolved Hide resolved
internal/database/migrations/0002_vulnerabilities.sql Outdated Show resolved Hide resolved
internal/database/migrations/0002_vulnerabilities.sql Outdated Show resolved Hide resolved
internal/database/migrations/0002_vulnerabilities.sql Outdated Show resolved Hide resolved
internal/graph/teams.resolvers.go Outdated Show resolved Hide resolved
internal/thirdparty/dependencytrack/fake/fake.go Outdated Show resolved Hide resolved
internal/thirdparty/dependencytrack/fake/fake.go Outdated Show resolved Hide resolved
internal/vulnerability/vulnerability_updater.go Outdated Show resolved Hide resolved
internal/cmd/api/vulnerability_metrics_updater.go Show resolved Hide resolved
rbjornstad and others added 10 commits February 13, 2024 09:24
@rbjornstad
Move vuln metric import to dependencyTrackConfig struct
58d65a0
@rbjornstad
Refactor runVulnerabilityUpdater
fb20940 
Not resetting ticker, instead do all logic before select.
@rbjornstad @ybelMekk
Update vulnerabilityMetrics date arguments to non-nullable.
fd0bcad 
Refactor db-migrations and queries.

Co-authored-by: ybelMekk <[email protected]>
@rbjornstad @ybelMekk
Refactor project ID variable names in Dependencytrack client
6d83ff8 
Co-authored-by: ybelMekk <[email protected]>
@rbjornstad
Add recover function to handle panics in vulnerability updater
44f411d
@rbjornstad @ybelMekk
Add github.com/sourcegraph/conc v0.3.0 as a required dependency***
90ebd0a 
***Refactor vulnerability_updater.go to improve performance and readability

Co-authored-by: ybelMekk <[email protected]>
@rbjornstad
Add .env to .gitignore
de5e050
@rbjornstad @ybelMekk
Use github.com/sourcegraph/conc/pool in upsert
e6f04c1 
Co-authored-by: ybelMekk <[email protected]>
@christeredvartsen
remove duplicate
7c3daae
@christeredvartsen
remove newline
d7d5335
christeredvartsen
christeredvartsen approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@christeredvartsen christeredvartsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@christeredvartsen christeredvartsen merged commit e58cc6f into main Feb 13, 2024
1 check passed
@christeredvartsen christeredvartsen deleted the vuln_count branch February 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thokra-nav thokra-nav thokra-nav requested changes

@christeredvartsen christeredvartsen christeredvartsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbjornstad @christeredvartsen @thokra-nav @ybelMekk @kimtore