New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secrets #3

Merged

Reasonable-Solutions merged 67 commits into main from secrets

Feb 22, 2024

Contributor

tronghn commented Feb 2, 2024 •

edited

Loading

See https://github.com/nais/system/pull/20.

thokra-nav reviewed

View reviewed changes

.envrc Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/auth/authz/authz.go Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/cmd/api/api.go Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/cmd/api/api.go Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/database/team.go Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/graph/graphqls/secrets.graphqls Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/graph/graphqls/secrets.graphqls Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/graph/secrets.resolvers.go Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/k8s/k8s.go Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/k8s/secrets.go Outdated Show resolved Hide resolved

thokra-nav reviewed

View reviewed changes

internal/k8s/secrets.go Outdated Show resolved Hide resolved

tronghn force-pushed the secrets branch 3 times, most recently from 1cbd6b0 to 21ce1ce Compare

February 9, 2024 06:57

tronghn changed the base branch from rm_reconciler_state to main

February 9, 2024 07:11

thokra-nav requested changes

View reviewed changes

Contributor

thokra-nav left a comment

Ser at alle filene i pkg/protoapi har blitt endret fordi det er generert med en annen versjon av protoc enn det som er definert i .tool-versions.
Lurer også på om vi ikke tar med .envrc, flake.* filene siden hele prosjektet per nå er satt opp med asdf, og blir ekstra vedlikehold å håndtere flere verktøy for samme jobb.

internal/graph/graphqls/secrets.graphqls Outdated Show resolved Hide resolved

tronghn force-pushed the secrets branch 2 times, most recently from e11d851 to bff0505 Compare

February 21, 2024 07:45

Reasonable-Solutions and others added 12 commits

February 21, 2024 13:23


          Add flake

c5f9bfc


          wip add a little data model for secrets

bdf1896


          stub out client

6af94de


          Secrets: Add graphql schema

987886c


          secret: generate

bc442b2


          secrets: Generate with input types

67beb52

radioactive waste


          secrets: use input types!


          secrets: Add a client for getting lists of secrets

7ef8daa


          secrets: correct signatures for mutations, add some todos

dda9259


          secrets: naive implementation of k8s client

fa79204


          secrets: initial implementation of resolvers

527eaf7


          secrets: add fake secret data to k8s

d680ac9

tronghn and others added 24 commits

February 21, 2024 13:23


          secrets: todos for validation

9822bca


          Secrets: Add custom errors for Secrets handling

34c1eef


          Secrets: Add errors for key and secret name validation

4f376c0


          Secrets: Implement endpoint for Get Secret name team env

d1c6fa8


          secrets: extract data validation

eea2f67


          secrets: improve error message for invalid name

5ae79ab


          Secrets: add more toolchain

4baf359


          secrets: rename sqlc imports, get group email directly from team

2ece4b8


          secrets: correct validation for data keys

579f0ac


          authz: refactor team membership check

df5c723


          style: address nitpicks

f72c5dc


          k8s: explicit nil check for group email

343a881


          secrets: simplify append, deduplicate nil check

b5c5f5b


          secrets: wip graphql query/types


          Secrets: move graph nodes around

27e9352


          secrets: return correct secrets for secrets field in apps

0a6fdf5


          secrets: correct field name for input tuple

0727dc9


          secrets: return some metadata for secret, add reloader annotation

1be016c


          local: add data for devteam

ed3a644


          secrets: add team field to type, refactor apps field resolver

8fd377e


          secrets: return flat list instead of grouping by environment

bf81a09


          move flake to .configs

e5b3bd1


          secrets: rename SecretTupleInput to VariableInput

8b31120


          all: generate

de5b8ef

tronghn force-pushed the secrets branch from bff0505 to de5b8ef Compare

February 21, 2024 12:26

thokra-nav approved these changes

View reviewed changes

tronghn added 2 commits

February 21, 2024 16:33


          add .envrc to .gitignore

ebae003


          secrets: address feedback from review

2ef3098

Reasonable-Solutions merged commit 793e029 into main

1 check passed

Reasonable-Solutions deleted the secrets branch

February 22, 2024 08:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet