Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to sort typed arrays #21

Open
arcusfelis opened this issue Feb 28, 2020 · 0 comments
Open

Allow to sort typed arrays #21

arcusfelis opened this issue Feb 28, 2020 · 0 comments

Comments

@arcusfelis
Copy link

Hi, nice work.

I have only one issue: "Can only sort arrays" error when sorting something like Int32Array.
Because of the usage of Array.isArray there https://github.com/mziccard/node-timsort/blob/master/src/timsort.js#L910

Array.isArray(new Int32Array(1))
false

Though, if the check is removed, the library works good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arcusfelis