Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Microsoft.Data.Sqlite results #10

Open
bricelam opened this issue Feb 12, 2019 · 2 comments
Open

Clean up Microsoft.Data.Sqlite results #10

bricelam opened this issue Feb 12, 2019 · 2 comments

Comments

@bricelam
Copy link
Contributor

Looks like I need to submit a PR to clean up some of our test results.

Notes:

  • Database doesn't support this data type
    • GetFieldType_for_Boolean
    • GetFieldType_for_Byte
    • GetFieldType_for_DateTime
    • GetFieldType_for_Decimal
    • GetFieldType_for_Guid
    • GetFieldType_for_Int16
    • GetFieldType_for_Int32
    • GetFieldType_for_Single
    • GetValue_for_Boolean
    • GetValue_for_Byte
    • GetValue_for_DateTime
    • GetValue_for_Decimal
    • GetValue_for_Guid
    • GetValue_for_Int16
    • GetValue_for_Int32
    • GetValue_for_Single
  • The provider does support these types
    • *_DateTimeOffset
    • *_SByte
    • *_UInt16
    • *_UInt32
    • *_UInt64
  • Should be fixed in version 2.2
    • GetBytes_*
    • GetChars_*
  • Provider doesn't support ordered parameters
    • ParameterName_can_be_set_to_null
@bgrainger
Copy link
Member

I should also update the tests from v2.0.0 and v2.1.0 to v2.2.2 and v3.0.0-preview.19074.3; if you haven't started your PR yet, I'll do that first to avoid conflicts later.

@bgrainger
Copy link
Member

I performed some of this cleanup (for MicrosoftSqlite) in cb1270e and 24ce49d.

You can see the difference in results (compared to MicrosoftSqlite22) in the latest output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants