Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate positional optional arguments for #to_xml #149

Open
mvz opened this issue Dec 2, 2020 · 0 comments
Open

Deprecate positional optional arguments for #to_xml #149

mvz opened this issue Dec 2, 2020 · 0 comments

Comments

@mvz
Copy link
Owner

mvz commented Dec 2, 2020

The #to_xml method supports optional arguments for recursion. Using positional arguments for this makes their use unclear so they should be replaced with optional keyword arguments.

Ideally, the recursive version should not be exposed to end users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvz