Improved comments and improved test code (mosaicml#1502)

mvpatel2000 · Sep 5, 2022 · 3bf3569 · 3bf3569
1 parent b9e8398
commit 3bf3569
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/composer/datasets/streaming/download.py b/composer/datasets/streaming/download.py
@@ -37,7 +37,7 @@ def get_object_store(remote: str) -> ObjectStore:
     elif remote.startswith('sftp://'):
         return _get_sftp_object_store(remote)
     else:
-        raise ValueError('unsupported upload scheme')
+        raise ValueError('unsupported download scheme')
 
 
 def _get_s3_object_store(remote: str) -> S3ObjectStore:
@@ -62,9 +62,6 @@ def _get_sftp_object_store(remote: str) -> SFTPObjectStore:
     return object_store
 
 
-__all__ = ['download_or_wait']
-
-
 def download_from_local(remote: str, local: str) -> None:
     """Download a file from remote to local.
 

diff --git a/tests/datasets/test_streaming.py b/tests/datasets/test_streaming.py
@@ -19,18 +19,18 @@
 
 @pytest.fixture
 def remote_local(tmp_path: pathlib.Path) -> Tuple[str, str]:
-    remote = tmp_path / 'remote'
-    local = tmp_path / 'local'
+    remote = tmp_path.joinpath('remote')
+    local = tmp_path.joinpath('local')
     remote.mkdir()
     local.mkdir()
     return str(remote), str(local)
 
 
 @pytest.fixture
 def compressed_remote_local(tmp_path: pathlib.Path) -> Tuple[str, str, str]:
-    compressed = tmp_path / 'compressed'
-    remote = tmp_path / 'remote'
-    local = tmp_path / 'local'
+    compressed = tmp_path.joinpath('compressed')
+    remote = tmp_path.joinpath('remote')
+    local = tmp_path.joinpath('local')
     list(x.mkdir() for x in [compressed, remote, local])
     return tuple(str(x) for x in [compressed, remote, local])