Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Conflict with Map Display from Custom-Block #56

Closed
abd-liac opened this issue Apr 29, 2024 · 5 comments
Closed

Minor Conflict with Map Display from Custom-Block #56

abd-liac opened this issue Apr 29, 2024 · 5 comments
Labels
plugins Related to plugins

Comments

@abd-liac
Copy link

abd-liac commented Apr 29, 2024

Support of Map Display comes with Custom-Block.

Problem
image

Reproducible only with pretty big font size; you can debug with quick adjust font size. (to operate, press control and scroll the wheel)

IMHO, it's due to some hardcoded CSS styles like height and width that caused the similar issues; so would consider make the theme more flexible, which it probably a major revision, when opportunity arises and time permits?

@mustakshif mustakshif added the plugins Related to plugins label Apr 29, 2024
@mustakshif
Copy link
Owner

Did you mean this plugin?
image

I tested the map list view and everything appears as expected on my end. Please check for any conflicting CSS snippets that might be affecting the display
截屏2024-04-29 18 00 58

@abd-liac
Copy link
Author

Correct plugin; archived minimal reproducible environment; updated description.

@mustakshif
Copy link
Owner

mustakshif commented Apr 29, 2024

Thank you for clarifying the problem description.

Reproducible only with pretty big font size; you can debug with quick adjust font size. (to operate, press control and scroll the wheel)

Yes, the problem appears when I enlarge the font size in my editor.

But since this issue also occurs with the default theme, I think it's best to report this to the plugin developer. They will likely be more familiar with the overall map view structure.

image

👆 map view in default daylight theme

@mustakshif
Copy link
Owner

IMHO, it's due to some hardcoded CSS styles like height and width that caused the similar issues; so would consider make the theme more flexible, which it probably a major revision, when opportunity arises and time permits?

Also, I'm with you on this. It's true that at times, I used hardcoded styles without testing them across different font sizes, especially during the early stages of developing for Asri. So, if you notice any related issues, please don't hesitate to report them.

@abd-liac
Copy link
Author

Reported upstream Zuoqiu-Yingyi/siyuan-plugin-custom-block#25.
Close for now, may reopen as needed.

Thanks for time on debugging and communicating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins Related to plugins
Projects
None yet
Development

No branches or pull requests

2 participants