-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of key element and/or clarification of keySig@pname #136
Comments
As you can see from the Guidelines <staffDef n="1" key.pname="e" key.mode="major">
<clef shape="G" line="2" />
<keySig sig="3s" />
<meterSig count="4" unit="4" />
</staffDef> |
Thanks. Is In other words, are these two equivalent in meaning: <staffDef n="1" key.pname="e" key.mode="major">
<clef shape="G" line="2" />
<keySig sig="3s" />
<meterSig count="4" unit="4" />
</staffDef> <staffDef n="1">
<clef shape="G" line="2" />
<keySig sig="3s" pname="e" mode="major" />
<meterSig count="4" unit="4" />
</staffDef> In other words, when I look for the key, then I will have to look in both places to find it? |
I would say yes, they're equivalent. |
Thanks! |
probably we should add some schematron rules pointing to the relation if both exist in an encoding or even contradict each other |
The key element:
https://music-encoding.org/guidelines/v4/elements/key.html
Is currently allowed to be contained in these element:
It was originally designed to be a header-specific description of the key for the work. However, it would be useful to allow in
<staffDef>
in particular in a similar manner to<keySig>
. Alternatively or in addition, it might be nice to allow as a subelement of<keySig>
.A motivation is to allow transposition by key in addition interval, as discussed in this issue: rism-digital/verovio#1189
Here is some example music in the key of A major:
Here is how the staffDef for the music could be formulated to represent A major (I presume):
One question is: is the above equivalent to the following:
Technically that looks like it should be equivalent to
<staffDef @keysig.pname="a" @keysig.mode="major">
...In other words, is
keySig@pname
+keySig@mode
independent or dependent onkeySig@sig
? Or in other words, what if these two descriptors are in conflict with each other? Or what happens ifkeySig@sig
is missing but the other two attributes are present?A related question would be how to encode the key independent of the key signature, particularly in the case of 16th-century music where the last accidental in the key signature is dropped as compared to modern conventions, such as displaying two flats when the music is in E-flat major?
A related problem is that the musical key can change due to modulation, and there is no key change at the point where the key changes. How should such a case be encoded (for analytic purposes)?
One possibility would be to promote
<key>
to have a function similar to<keySig>
within the music:This would then be equivalent to:
The text was updated successfully, but these errors were encountered: