Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 16 Holes C Chromatic Harmonica Standard Tuning. #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Ismael-VC
Copy link

@Ismael-VC Ismael-VC commented Sep 27, 2021

  • I have updated the README, to reflect what the plugin actually does.
  • Added support for the 16 hole chromatic harp.
  • fixed a bug with tabbing the D7 note in standard chromatic:
// C7,   C#7,    D7  < ---this is wrong, should be "-12s" not "-12" which corresponds to B6 not D7!     
"+12", "+12s", "-12", "-12s" ]; 

Make convention description reflect what the plugin actually does.
Include tuning for 16 Holes Chromatic Harmonica and special case when tuning is C as opposed to Low C (which is used as starting point), so that it uses Low C automatically if 16 Holes Chromatic tuning is selected.
@Ismael-VC
Copy link
Author

@vpereverzev @Ximich sorry to bother you, since you are the only ones in the musescore organization I would like to request if you can please check this out, else may I join this repo as contributor? I could check out all the other PR and issues and take maintenance of this plugin.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant