Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25471: Brackets always added to first staff #25474

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

XiaoMigros
Copy link
Contributor

Resolves: #25471

Seems some of the code previously removed was necessary after all. Thanks @sammik !

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Copy link
Contributor

@mathesoncalum mathesoncalum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems some of the code previously removed was necessary after all.

Ah, was worth a try...

Just one suggestion - I'd still prefer the changes suggested here for readability reasons. There's just a smidge too much going on in one line right now for my liking (sorry I know that's a real nitpick).

Thanks!

@mathesoncalum mathesoncalum changed the title Fix #25471 Fix #25471: Brackets always edded to first staff Nov 11, 2024
@XiaoMigros XiaoMigros changed the title Fix #25471: Brackets always edded to first staff Fix #25471: Brackets always added to first staff Nov 12, 2024
@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved
#25471 FIXED

@mathesoncalum mathesoncalum merged commit a5bbbae into musescore:master Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bracket always created on first staff. (Master Version)
3 participants