Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fretboard diagram when its attached chord symbol is changed #25462

Open
avvvvve opened this issue Nov 7, 2024 · 2 comments
Open

Update fretboard diagram when its attached chord symbol is changed #25462

avvvvve opened this issue Nov 7, 2024 · 2 comments
Assignees

Comments

@avvvvve
Copy link

avvvvve commented Nov 7, 2024

Problem

When you add a fretboard diagram to a score, it comes with an attached chord symbol element. Double-clicking into the chord symbol text lets you edit the chord (which is reflected correctly in playback), but doing so does not update the attached fretboard diagram.

Screen.Recording.2024-11-07.at.6.25.56.PM.mov

Solution

Fretboard diagrams need to check what the chord symbol they are attached to is, and update accordingly.

For example, this should be possible:

  1. Open the 'Fretboard diagram' palette and add a C chord.
  2. Double click on the 'C' chord symbol in the score
  3. Type in 'Cm' and click out of the field
  4. See that the fretboard diagram updates to the Cm shape

This means that each chord symbol that MuseScore Studio can play back also needs a fretboard diagram assigned to it, which is a larger task to be completed alongside this one, likely with @bkunda's help. (Eventually we will add options to choose between different diagram shapes/positions for the same chord)

This is also the first step to enabling transposition of fretboard diagrams and chord symbols.

@scorster
Copy link

scorster commented Nov 8, 2024

@ avvvvve Paraphrased Fretboard diagrams should check the chord quality of the chord symbol they to which they are attached, and update accordingly when the user changes the chord symbol.

Nice idea!

And if there are multiple fretboard diagrams for the newly entered chord symbol, like your exampled Cm, then show some sort of dialog or picker where the user can easily select among C minor fretboard diagrams voicings. I can also see the helpfulness of the option for "No fretboard diagram."

@bkunda
Copy link

bkunda commented Nov 11, 2024

like your exampled Cm, then show some sort of dialog or picker where the user can easily select among C minor fretboard diagrams voicings

We will eventually do this, but it's out of scope for the initial feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

5 participants