Get number of shards from observers #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
reviewed
Sep 30, 2024
cmd/proxy/main.go
Outdated
Comment on lines
411
to
431
| httpClient := &http.Client{} | ||
| httpClient.Timeout = time.Duration(cfg.GeneralSettings.RequestTimeoutSec) * time.Second | ||
| observersList := make([]string, 0, len(cfg.Observers)) | ||
| for _, node := range cfg.Observers { | ||
| observersList = append(observersList, node.Address) | ||
| } | ||
| argsNumShardsProcessor := process.ArgNumShardsProcessor{ | ||
| HttpClient: httpClient, | ||
| Observers: observersList, | ||
| TimeBetweenNodesRequestsInSec: cfg.GeneralSettings.TimeBetweenNodesRequestsInSec, | ||
| NumShardsTimeoutInSec: cfg.GeneralSettings.NumShardsTimeoutInSec, | ||
| RequestTimeoutInSec: cfg.GeneralSettings.RequestTimeoutSec, | ||
| } | ||
| numShardsProcessor, err := process.NewNumShardsProcessor(argsNumShardsProcessor) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| numShards, err := numShardsProcessor.GetNetworkNumShards(ctx) | ||
| cancel() |
There was a problem hiding this comment.
maybe we can extract this into a separate func for getting the number of shards, since the component is created only for this usage
bogdan-rosianu
approved these changes
Oct 1, 2024
ssd04
approved these changes
Oct 1, 2024
gabi-vuls
approved these changes
Oct 3, 2024
liviuf-ancas
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.