Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated endpoint from proxy: address/:address/transactions #454

Merged

Conversation

danielailie
Copy link

@danielailie danielailie commented Aug 1, 2024

Remove code for deprecated endpoint

This endpoint was decommission on Monday 13.11.2023 and the documentation was updated accordingly.

AdoAdoAdo
AdoAdoAdo previously approved these changes Aug 1, 2024
Copy link
Contributor

@andreibancioiu andreibancioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elvisboghiu elvisboghiu self-requested a review August 2, 2024 14:40
Copy link

@elvisboghiu elvisboghiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test
Normal allin test: v1.7.13-dev-config-aebb55e8e0 -> v1.7.13-dev-config-aebb55e8e0

--- Specific errors ---

block hash does not match 644
wrong nonce in block 351
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 231
Nr. of new ERRORS: 0
Nr. of new WARNS: 16
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

ovh-p04-validator-28 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2

ovh-p04-validator-31 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

ovh-p04-validator-21 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

ovh-p04-validator-15 :
Warn: trie recreate error: error = getNodeFromDB error: key not found for key root = 1

ovh-p04-validator-5 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

ovh-p04-validator-8 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2

ovh-p04-validator-35 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

ovh-p04-observer-4 :
Warn: trie recreate error: error = getNodeFromDB error: key not found for key root = 1

ovh-p04-validator-12 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

ovh-p04-validator-34 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

ovh-p04-validator-17 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 3

ovh-p04-validator-27 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 1

/------/

@danielailie danielailie changed the title Remove deprecated endpoint from proxy Remove deprecated endpoint from proxy address/:address/transactions Aug 5, 2024
@danielailie danielailie changed the title Remove deprecated endpoint from proxy address/:address/transactions Remove deprecated endpoint from proxy: address/:address/transactions Aug 5, 2024
@danielailie danielailie merged commit ceb38a0 into rc/v1.7.next1 Aug 5, 2024
5 checks passed
@danielailie danielailie deleted the MX-15698-remove-deprecated-endpoint-from-proxy branch August 5, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants