From dd7d971672af6b70328742c41365cfaadd102f83 Mon Sep 17 00:00:00 2001 From: Sorin Stanculeanu Date: Mon, 29 Jul 2024 11:38:27 +0300 Subject: [PATCH 1/4] updated deps --- go.mod | 8 ++++---- go.sum | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/go.mod b/go.mod index 2ace1a0a..fbb90512 100644 --- a/go.mod +++ b/go.mod @@ -8,10 +8,10 @@ require ( github.com/gin-contrib/pprof v1.4.0 github.com/gin-contrib/static v0.0.1 github.com/gin-gonic/gin v1.9.1 - github.com/multiversx/mx-chain-core-go v1.2.21-0.20240725065431-6e9bfee5a4c6 - github.com/multiversx/mx-chain-crypto-go v1.2.12-0.20240725071000-c3212540166f - github.com/multiversx/mx-chain-es-indexer-go v1.7.3-0.20240725073933-b3457c5308ca - github.com/multiversx/mx-chain-logger-go v1.0.15-0.20240725065747-176bd697c775 + github.com/multiversx/mx-chain-core-go v1.2.21 + github.com/multiversx/mx-chain-crypto-go v1.2.12 + github.com/multiversx/mx-chain-es-indexer-go v1.7.4 + github.com/multiversx/mx-chain-logger-go v1.0.15 github.com/pkg/errors v0.9.1 github.com/stretchr/testify v1.8.4 github.com/urfave/cli v1.22.10 diff --git a/go.sum b/go.sum index 9b19a00d..3ff90b70 100644 --- a/go.sum +++ b/go.sum @@ -131,14 +131,14 @@ github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9G github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk= github.com/mr-tron/base58 v1.2.0 h1:T/HDJBh4ZCPbU39/+c3rRvE0uKBQlU27+QI8LJ4t64o= github.com/mr-tron/base58 v1.2.0/go.mod h1:BinMc/sQntlIE1frQmRFPUoPA1Zkr8VRgBdjWI2mNwc= -github.com/multiversx/mx-chain-core-go v1.2.21-0.20240725065431-6e9bfee5a4c6 h1:Q7uUjTYTrt8Mw9oq5JWPv+WHhpxHTv6lhZZlhPuNcoQ= -github.com/multiversx/mx-chain-core-go v1.2.21-0.20240725065431-6e9bfee5a4c6/go.mod h1:B5zU4MFyJezmEzCsAHE9YNULmGCm2zbPHvl9hazNxmE= -github.com/multiversx/mx-chain-crypto-go v1.2.12-0.20240725071000-c3212540166f h1:jydjrmVFvSllBOTppveOAkLITpOYKk0kma5z0bfDImI= -github.com/multiversx/mx-chain-crypto-go v1.2.12-0.20240725071000-c3212540166f/go.mod h1:9aSp//uBSvqFdzh4gvYISraoruhr1FCTXgPQalQ687k= -github.com/multiversx/mx-chain-es-indexer-go v1.7.3-0.20240725073933-b3457c5308ca h1:9b2yFAarWDG/jTYePv0UqNWQ9gxeSZy9mGxtd8dFj2Y= -github.com/multiversx/mx-chain-es-indexer-go v1.7.3-0.20240725073933-b3457c5308ca/go.mod h1:bHPP5zerhmbRfVcbfXgpMPUaTKMrK6gGi+rRbw0BpDE= -github.com/multiversx/mx-chain-logger-go v1.0.15-0.20240725065747-176bd697c775 h1:a8LOfz3p4MQfRtbF00rGDAJiebziwtSfVmBHIaHBDdY= -github.com/multiversx/mx-chain-logger-go v1.0.15-0.20240725065747-176bd697c775/go.mod h1:owPYyrK7RcsLx9eOCAZQ22fIyW6BE7ttJr4XIhFIbQw= +github.com/multiversx/mx-chain-core-go v1.2.21 h1:+XVKznPTlUU5EFS1A8chtS8fStW60upRIyF4Pgml19I= +github.com/multiversx/mx-chain-core-go v1.2.21/go.mod h1:B5zU4MFyJezmEzCsAHE9YNULmGCm2zbPHvl9hazNxmE= +github.com/multiversx/mx-chain-crypto-go v1.2.12 h1:zWip7rpUS4CGthJxfKn5MZfMfYPjVjIiCID6uX5BSOk= +github.com/multiversx/mx-chain-crypto-go v1.2.12/go.mod h1:HzcPpCm1zanNct/6h2rIh+MFrlXbjA5C8+uMyXj3LI4= +github.com/multiversx/mx-chain-es-indexer-go v1.7.4 h1:SjJk9G9SN8baz0sFIU2jymYCfx3XiikGEB2wW0jwvfw= +github.com/multiversx/mx-chain-es-indexer-go v1.7.4/go.mod h1:oGcRK2E3Syv6vRTszWrrb/TqD8akq0yeoMr1wPPiTO4= +github.com/multiversx/mx-chain-logger-go v1.0.15 h1:HlNdK8etyJyL9NQ+6mIXyKPEBo+wRqOwi3n+m2QIHXc= +github.com/multiversx/mx-chain-logger-go v1.0.15/go.mod h1:t3PRKaWB1M+i6gUfD27KXgzLJJC+mAQiN+FLlL1yoGQ= github.com/nxadm/tail v1.4.4/go.mod h1:kenIhsEOeOJmVchQTgglprH7qJGnHDVpk1VPCcaMI8A= github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= github.com/onsi/ginkgo v1.7.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= From 2487bb1fc8b7815b347cc5f20b7803dcd0864acb Mon Sep 17 00:00:00 2001 From: danielailie Date: Thu, 1 Aug 2024 15:46:10 +0300 Subject: [PATCH 2/4] Remove code for address/:address/transactions --- .gitignore | 1 + README.md | 1 - api/groups/baseAccountsGroup.go | 22 ---------- api/groups/interface.go | 1 - cmd/proxy/config/apiConfig/v1_0.toml | 1 - cmd/proxy/config/apiConfig/v_next.toml | 1 - cmd/proxy/config/swagger/openapi.json | 44 +++---------------- facade/baseFacade.go | 5 --- facade/interface.go | 1 - facade/mock/accountProccessorStub.go | 5 --- process/accountProcessor.go | 9 ---- process/accountProcessor_test.go | 20 --------- process/database/elasticSearchConnector.go | 10 ----- .../database/elasticSearchConnector_test.go | 14 ------ process/interface.go | 1 - process/mock/elasticSearchConnectorMock.go | 5 --- process/mock/externalStorageConnectorStub.go | 10 ----- 17 files changed, 7 insertions(+), 144 deletions(-) diff --git a/.gitignore b/.gitignore index 44e69658..a4530dd0 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,4 @@ .idea/ vendor/ +cmd/proxy/proxy diff --git a/README.md b/README.md index bef3670e..5967add5 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,6 @@ For more details, go [here](https://docs.multiversx.com/sdk-and-tools/proxy/). - `/v1.0/address/:address/shard` (GET) --> returns the shard of an :address based on current proxy's configuration. - `/v1.0/address/:address/keys ` (GET) --> returns the key-value pairs of an :address. - `/v1.0/address/:address/storage/:key` (GET) --> returns the value for a given key for an account. -- `/v1.0/address/:address/transactions` (GET) --> returns the transactions stored in indexer for a given :address. - `/v1.0/address/:address/esdt` (GET) --> returns the account's ESDT tokens list for the given :address. - `/v1.0/address/:address/esdt/:tokenIdentifier` (GET) --> returns the token data for a given :address and ESDT token, such as balance and properties. - `/v1.0/address/:address/esdts-with-role/:role` (GET) --> returns the token identifiers for a given :address and the provided role. diff --git a/api/groups/baseAccountsGroup.go b/api/groups/baseAccountsGroup.go index 62ea2592..2daaca58 100644 --- a/api/groups/baseAccountsGroup.go +++ b/api/groups/baseAccountsGroup.go @@ -34,7 +34,6 @@ func NewAccountsGroup(facadeHandler data.FacadeHandler) (*accountsGroup, error) {Path: "/:address/nonce", Handler: ag.getNonce, Method: http.MethodGet}, {Path: "/:address/shard", Handler: ag.getShard, Method: http.MethodGet}, {Path: "/:address/code-hash", Handler: ag.getCodeHash, Method: http.MethodGet}, - {Path: "/:address/transactions", Handler: ag.getTransactions, Method: http.MethodGet}, {Path: "/:address/keys", Handler: ag.getKeyValuePairs, Method: http.MethodGet}, {Path: "/:address/key/:key", Handler: ag.getValueForKey, Method: http.MethodGet}, {Path: "/:address/esdt", Handler: ag.getESDTTokens, Method: http.MethodGet}, @@ -71,16 +70,6 @@ func (group *accountsGroup) respondWithAccount(c *gin.Context, transform func(*d shared.RespondWith(c, http.StatusOK, response, "", data.ReturnCodeSuccess) } -func (group *accountsGroup) getTransactionsFromFacade(c *gin.Context) ([]data.DatabaseTransaction, int, error) { - addr := c.Param("address") - transactions, err := group.facade.GetTransactions(addr) - if err != nil { - return nil, http.StatusInternalServerError, err - } - - return transactions, http.StatusOK, nil -} - // getAccount returns an accountResponse containing information // about the account correlated with provided address func (group *accountsGroup) getAccount(c *gin.Context) { @@ -157,17 +146,6 @@ func (group *accountsGroup) getAccounts(c *gin.Context) { shared.RespondWith(c, http.StatusOK, response, "", data.ReturnCodeSuccess) } -// getTransactions returns the transactions for the address parameter -func (group *accountsGroup) getTransactions(c *gin.Context) { - transactions, status, err := group.getTransactionsFromFacade(c) - if err != nil { - shared.RespondWith(c, status, nil, err.Error(), data.ReturnCodeInternalError) - return - } - - shared.RespondWith(c, http.StatusOK, gin.H{"transactions": transactions}, "", data.ReturnCodeSuccess) -} - // getKeyValuePairs returns the key-value pairs for the address parameter func (group *accountsGroup) getKeyValuePairs(c *gin.Context) { addr := c.Param("address") diff --git a/api/groups/interface.go b/api/groups/interface.go index a4c18868..c97a076b 100644 --- a/api/groups/interface.go +++ b/api/groups/interface.go @@ -13,7 +13,6 @@ import ( type AccountsFacadeHandler interface { GetAccount(address string, options common.AccountQueryOptions) (*data.AccountModel, error) GetCodeHash(address string, options common.AccountQueryOptions) (*data.GenericAPIResponse, error) - GetTransactions(address string) ([]data.DatabaseTransaction, error) GetShardIDForAddress(address string) (uint32, error) GetValueForKey(address string, key string, options common.AccountQueryOptions) (string, error) GetAllESDTTokens(address string, options common.AccountQueryOptions) (*data.GenericAPIResponse, error) diff --git a/cmd/proxy/config/apiConfig/v1_0.toml b/cmd/proxy/config/apiConfig/v1_0.toml index 1f5d2aed..6bfd4d85 100644 --- a/cmd/proxy/config/apiConfig/v1_0.toml +++ b/cmd/proxy/config/apiConfig/v1_0.toml @@ -45,7 +45,6 @@ Routes = [ { Name = "/:address/registered-nfts", Open = true, Secured = false, RateLimit = 0 }, { Name = "/:address/nft/:tokenIdentifier/nonce/:nonce", Open = true, Secured = false, RateLimit = 0 }, { Name = "/:address/shard", Open = true, Secured = false, RateLimit = 0 }, - { Name = "/:address/transactions", Open = true, Secured = false, RateLimit = 0 }, { Name = "/:address/guardian-data", Open = true, Secured = false, RateLimit = 0 }, { Name = "/:address/is-data-trie-migrated", Open = true, Secured = false, RateLimit = 0 } ] diff --git a/cmd/proxy/config/apiConfig/v_next.toml b/cmd/proxy/config/apiConfig/v_next.toml index 1bdf4e85..8fdb4dd1 100644 --- a/cmd/proxy/config/apiConfig/v_next.toml +++ b/cmd/proxy/config/apiConfig/v_next.toml @@ -45,7 +45,6 @@ Routes = [ { Name = "/:address/registered-nfts", Open = true, Secured = false, RateLimit = 0 }, { Name = "/:address/nft/:tokenIdentifier/nonce/:nonce", Open = true, Secured = false, RateLimit = 0 }, { Name = "/:address/shard", Open = true, Secured = false, RateLimit = 0 }, - { Name = "/:address/transactions", Open = true, Secured = false, RateLimit = 0 }, { Name = "/:address/guardian-data", Open = true, Secured = false, RateLimit = 0 }, { Name = "/:address/is-data-trie-migrated", Open = true, Secured = false, RateLimit = 0 } ] diff --git a/cmd/proxy/config/swagger/openapi.json b/cmd/proxy/config/swagger/openapi.json index 05c1e5b9..f27cc0a1 100644 --- a/cmd/proxy/config/swagger/openapi.json +++ b/cmd/proxy/config/swagger/openapi.json @@ -270,38 +270,6 @@ } } }, - "/address/{address}/transactions": { - "get": { - "tags": [ - "address" - ], - "summary": "returns the transactions of the provided address", - "parameters": [ - { - "name": "address", - "in": "path", - "description": "the address in bech32 format", - "required": true, - "schema": { - "type": "string", - "default": null - } - } - ], - "responses": { - "200": { - "description": "successful operation", - "content": { - "application/json": { - "schema": { - "$ref": "#/components/schemas/AddressTransactions" - } - } - } - } - } - } - }, "/address/{address}/key/{key}": { "get": { "tags": [ @@ -2671,7 +2639,7 @@ "name": "fields", "in": "query", "description": "the requested transaction fields, comma sepparated. If none provided, only hash is returned. Possible values are: hash, nonce, sender, receiver, gaslimit, gasprice, receiverusername, data, value", - "schema" : { + "schema": { "type": "string", "default": null } @@ -2680,7 +2648,7 @@ "name": "shard-id", "in": "query", "description": "the shard id to return transactions pool", - "schema" : { + "schema": { "type": "string", "default": null } @@ -2689,7 +2657,7 @@ "name": "by-sender", "in": "query", "description": "the bech32 address of transactions' sender", - "schema" : { + "schema": { "type": "string", "default": null } @@ -2698,7 +2666,7 @@ "name": "last-nonce", "in": "query", "description": "returns the last nonce from pool. This parameter requires by-sender and does not work with fields", - "schema" : { + "schema": { "type": "boolean", "default": false } @@ -2707,7 +2675,7 @@ "name": "nonce-gaps", "in": "query", "description": "returns the nonce gaps from pool. This parameter requires by-sender and does not work with fields", - "schema" : { + "schema": { "type": "boolean", "default": false } @@ -3271,4 +3239,4 @@ } } } -} +} \ No newline at end of file diff --git a/facade/baseFacade.go b/facade/baseFacade.go index 01e04910..525937d7 100644 --- a/facade/baseFacade.go +++ b/facade/baseFacade.go @@ -161,11 +161,6 @@ func (pf *ProxyFacade) GetShardIDForAddress(address string) (uint32, error) { return pf.accountProc.GetShardIDForAddress(address) } -// GetTransactions returns transactions by address -func (pf *ProxyFacade) GetTransactions(address string) ([]data.DatabaseTransaction, error) { - return pf.accountProc.GetTransactions(address) -} - // GetESDTTokenData returns the token data for a given token name func (pf *ProxyFacade) GetESDTTokenData(address string, key string, options common.AccountQueryOptions) (*data.GenericAPIResponse, error) { return pf.accountProc.GetESDTTokenData(address, key, options) diff --git a/facade/interface.go b/facade/interface.go index a76d8edc..ac29e844 100644 --- a/facade/interface.go +++ b/facade/interface.go @@ -22,7 +22,6 @@ type AccountProcessor interface { GetAccounts(addresses []string, options common.AccountQueryOptions) (*data.AccountsModel, error) GetShardIDForAddress(address string) (uint32, error) GetValueForKey(address string, key string, options common.AccountQueryOptions) (string, error) - GetTransactions(address string) ([]data.DatabaseTransaction, error) GetAllESDTTokens(address string, options common.AccountQueryOptions) (*data.GenericAPIResponse, error) GetKeyValuePairs(address string, options common.AccountQueryOptions) (*data.GenericAPIResponse, error) GetESDTTokenData(address string, key string, options common.AccountQueryOptions) (*data.GenericAPIResponse, error) diff --git a/facade/mock/accountProccessorStub.go b/facade/mock/accountProccessorStub.go index e50e728c..03c6943e 100644 --- a/facade/mock/accountProccessorStub.go +++ b/facade/mock/accountProccessorStub.go @@ -89,11 +89,6 @@ func (aps *AccountProcessorStub) GetShardIDForAddress(address string) (uint32, e return aps.GetShardIDForAddressCalled(address) } -// GetTransactions - -func (aps *AccountProcessorStub) GetTransactions(address string) ([]data.DatabaseTransaction, error) { - return aps.GetTransactionsCalled(address) -} - // GetCodeHash - func (aps *AccountProcessorStub) GetCodeHash(address string, options common.AccountQueryOptions) (*data.GenericAPIResponse, error) { return aps.GetCodeHashCalled(address, options) diff --git a/process/accountProcessor.go b/process/accountProcessor.go index 22465f38..a749a4f0 100644 --- a/process/accountProcessor.go +++ b/process/accountProcessor.go @@ -452,15 +452,6 @@ func (ap *AccountProcessor) GetGuardianData(address string, options common.Accou return nil, WrapObserversError(apiResponse.Error) } -// GetTransactions resolves the request and returns a slice of transaction for the specific address -func (ap *AccountProcessor) GetTransactions(address string) ([]data.DatabaseTransaction, error) { - if _, err := ap.pubKeyConverter.Decode(address); err != nil { - return nil, fmt.Errorf("%w, %v", ErrInvalidAddress, err) - } - - return ap.connector.GetTransactionsByAddress(address) -} - // GetCodeHash returns the code hash for a given address func (ap *AccountProcessor) GetCodeHash(address string, options common.AccountQueryOptions) (*data.GenericAPIResponse, error) { availability := ap.availabilityProvider.AvailabilityForAccountQueryOptions(options) diff --git a/process/accountProcessor_test.go b/process/accountProcessor_test.go index b06959f2..608c0ebf 100644 --- a/process/accountProcessor_test.go +++ b/process/accountProcessor_test.go @@ -286,26 +286,6 @@ func TestAccountProcessor_GetShardIDForAddressShouldError(t *testing.T) { assert.Equal(t, expectedError, err) } -func TestAccountProcessor_GetTransactions(t *testing.T) { - t.Parallel() - - converter, _ := pubkeyConverter.NewBech32PubkeyConverter(32, "erd") - ap, _ := process.NewAccountProcessor( - &mock.ProcessorStub{}, - converter, - &mock.ElasticSearchConnectorMock{}, - ) - - _, err := ap.GetTransactions("invalidAddress") - assert.True(t, errors.Is(err, process.ErrInvalidAddress)) - - _, err = ap.GetTransactions("") - assert.True(t, errors.Is(err, process.ErrInvalidAddress)) - - _, err = ap.GetTransactions("erd1ycega644rvjtgtyd8hfzt6hl5ymaa8ml2nhhs5cv045cz5vxm00q022myr") - assert.Nil(t, err) -} - func TestAccountProcessor_GetESDTsWithRoleGetObserversFails(t *testing.T) { t.Parallel() diff --git a/process/database/elasticSearchConnector.go b/process/database/elasticSearchConnector.go index bc9e1573..0b6cd4c7 100644 --- a/process/database/elasticSearchConnector.go +++ b/process/database/elasticSearchConnector.go @@ -35,16 +35,6 @@ func NewElasticSearchConnector(url, username, password string) (*elasticSearchCo }, nil } -// GetTransactionsByAddress gets transactions TO or FROM the specified address -func (esc *elasticSearchConnector) GetTransactionsByAddress(address string) ([]data.DatabaseTransaction, error) { - decodedBody, err := esc.doSearchRequestTx(address, "transactions", numTopTransactions) - if err != nil { - return nil, err - } - - return convertObjectToTransactions(decodedBody) -} - // GetAtlasBlockByShardIDAndNonce gets from database a block with the specified shardID and nonce func (esc *elasticSearchConnector) GetAtlasBlockByShardIDAndNonce(shardID uint32, nonce uint64) (data.AtlasBlock, error) { query := blockByNonceAndShardIDQuery(nonce, shardID) diff --git a/process/database/elasticSearchConnector_test.go b/process/database/elasticSearchConnector_test.go index b6d6d991..2b6b1949 100644 --- a/process/database/elasticSearchConnector_test.go +++ b/process/database/elasticSearchConnector_test.go @@ -8,20 +8,6 @@ import ( "github.com/stretchr/testify/require" ) -func TestDatabaseReader(t *testing.T) { - t.Skip("this test queries Elastic Search") - - url := "https://elastic-aws.multiversx.com" - user := "" - password := "" - reader, err := NewElasticSearchConnector(url, user, password) - require.Nil(t, err) - - addr := "erd1ewshdn9yv0wx38xgs5cdhvcq4dz0n7tdlgh8wfj9nxugwmyunnyqpkpzal" - txs, err := reader.GetTransactionsByAddress(addr) - fmt.Println(txs) - require.Nil(t, err) -} func TestDatabaseReader_GetBlockByShardIDAndNonce(t *testing.T) { t.Skip("this test queries Elastic Search") diff --git a/process/interface.go b/process/interface.go index b6762d80..bbfb5932 100644 --- a/process/interface.go +++ b/process/interface.go @@ -31,7 +31,6 @@ type Processor interface { // ExternalStorageConnector defines what a external storage connector should be able to do type ExternalStorageConnector interface { - GetTransactionsByAddress(address string) ([]data.DatabaseTransaction, error) GetAtlasBlockByShardIDAndNonce(shardID uint32, nonce uint64) (data.AtlasBlock, error) IsInterfaceNil() bool } diff --git a/process/mock/elasticSearchConnectorMock.go b/process/mock/elasticSearchConnectorMock.go index ee174772..b6c97769 100644 --- a/process/mock/elasticSearchConnectorMock.go +++ b/process/mock/elasticSearchConnectorMock.go @@ -5,11 +5,6 @@ import "github.com/multiversx/mx-chain-proxy-go/data" type ElasticSearchConnectorMock struct { } -// GetTransactionsByAddress - -func (escm *ElasticSearchConnectorMock) GetTransactionsByAddress(_ string) ([]data.DatabaseTransaction, error) { - return nil, nil -} - // GetAtlasBlockByShardIDAndNonce - func (escm *ElasticSearchConnectorMock) GetAtlasBlockByShardIDAndNonce(_ uint32, _ uint64) (data.AtlasBlock, error) { return data.AtlasBlock{}, nil diff --git a/process/mock/externalStorageConnectorStub.go b/process/mock/externalStorageConnectorStub.go index 43a5873f..febec410 100644 --- a/process/mock/externalStorageConnectorStub.go +++ b/process/mock/externalStorageConnectorStub.go @@ -3,19 +3,9 @@ package mock import "github.com/multiversx/mx-chain-proxy-go/data" type ExternalStorageConnectorStub struct { - GetTransactionsByAddressCalled func(address string) ([]data.DatabaseTransaction, error) GetAtlasBlockByShardIDAndNonceCalled func(shardID uint32, nonce uint64) (data.AtlasBlock, error) } -// GetTransactionsByAddress - -func (e *ExternalStorageConnectorStub) GetTransactionsByAddress(address string) ([]data.DatabaseTransaction, error) { - if e.GetTransactionsByAddressCalled != nil { - return e.GetTransactionsByAddressCalled(address) - } - - return []data.DatabaseTransaction{{Fee: "0"}}, nil -} - // GetAtlasBlockByShardIDAndNonce - func (e *ExternalStorageConnectorStub) GetAtlasBlockByShardIDAndNonce(shardID uint32, nonce uint64) (data.AtlasBlock, error) { if e.GetAtlasBlockByShardIDAndNonceCalled != nil { From 39b655cb2d0706a000ce7e38b38355548303ed4d Mon Sep 17 00:00:00 2001 From: danielailie Date: Thu, 1 Aug 2024 15:59:19 +0300 Subject: [PATCH 3/4] Add empty new line at the and of file --- cmd/proxy/config/swagger/openapi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/proxy/config/swagger/openapi.json b/cmd/proxy/config/swagger/openapi.json index f27cc0a1..075ef6bc 100644 --- a/cmd/proxy/config/swagger/openapi.json +++ b/cmd/proxy/config/swagger/openapi.json @@ -3239,4 +3239,4 @@ } } } -} \ No newline at end of file +} From e8a085ae8afdd931476e93bb399ce89bc22fd81e Mon Sep 17 00:00:00 2001 From: ssd04 Date: Thu, 1 Aug 2024 16:54:29 +0300 Subject: [PATCH 4/4] fix swagger esdts roles endpoint --- cmd/proxy/config/swagger/openapi.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/proxy/config/swagger/openapi.json b/cmd/proxy/config/swagger/openapi.json index 05c1e5b9..cdcbc189 100644 --- a/cmd/proxy/config/swagger/openapi.json +++ b/cmd/proxy/config/swagger/openapi.json @@ -375,7 +375,7 @@ } } }, - "/address/{address}/esdt/roles": { + "/address/{address}/esdts/roles": { "get": { "tags": [ "address"