-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highlight nodes shuffled out to auction list #6166
Conversation
integrationTests/chainSimulator/staking/stake/stakeAndUnStake_test.go
Outdated
Show resolved
Hide resolved
integrationTests/chainSimulator/staking/stake/stakeAndUnStake_test.go
Outdated
Show resolved
Hide resolved
The base branch was changed.
@@ -212,6 +212,7 @@ func epochValidatorsToEpochNodesConfig(config EpochValidatorsHandler) (*epochNod | |||
if err != nil { | |||
return nil, err | |||
} | |||
result.lowWaitingList = configWithAuction.GetLowWaitingList() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename these variables to reflect these are bool variables (e.g.: is/wasLowWaitingList?) otherwise, it looks like we are querying a list of nodes
@@ -61,7 +61,7 @@ func displayNodesConfigInfo(config map[uint32]*epochNodesConfig) { | |||
|
|||
func (ihnc *indexHashedNodesCoordinator) saveState(key []byte, epoch uint32) error { | |||
registry := ihnc.NodesCoordinatorToRegistry(epoch) | |||
data, err := ihnc.nodesCoordinatorRegistryFactory.GetRegistryData(registry, ihnc.currentEpoch) | |||
data, err := ihnc.nodesCoordinatorRegistryFactory.GetRegistryData(registry, epoch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were these 2 always equal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, when executing EpochStartPrepare these are not equal. But then the state is saved again when these are equal, so it was still ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: v1.7.10-dev-config-c267fd1a5f -> auction-from-shuffled-out-1dd6e0755e
--- Specific errors ---
block hash does not match 273
wrong nonce in block 231
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 255
Nr. of new ERRORS: 0
Nr. of new WARNS: 16
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested also with half-half and with a specific scenario ✅
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?