Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sirius patch 2 rc v1.7.0 2024.01.31 #5898

Merged

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2a3c3d) 80.32% compared to head (10d4798) 80.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           rc/v1.7.0    #5898   +/-   ##
==========================================
  Coverage      80.32%   80.33%           
==========================================
  Files            710      710           
  Lines          94069    94073    +4     
==========================================
+ Hits           75563    75569    +6     
+ Misses         13222    13221    -1     
+ Partials        5284     5283    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-06f147d698 -> update-sirius-patch-2-rc-v-10d4798780

--- Specific errors ---

block hash does not match 5147
wrong nonce in block 1959
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 520
Nr. of new ERRORS: 0
Nr. of new WARNS: 5
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

@iulianpascalau iulianpascalau merged commit e2fe9e0 into rc/v1.7.0 Feb 1, 2024
10 checks passed
@iulianpascalau iulianpascalau deleted the update-sirius-patch-2-rc-v1.7.0-2024.01.31 branch February 1, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants