Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add back subscribed events for outgoing operations #5865

Merged

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Jan 23, 2024

Reasoning behind the pull request

  • Add back subscribed events for outgoing operations

Testing procedure

  • Local testnet

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6e8ced) 79.34% compared to head (5fbacee) 79.33%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           feat/chain-go-sdk    #5865      +/-   ##
=====================================================
- Coverage              79.34%   79.33%   -0.01%     
=====================================================
  Files                    784      784              
  Lines                  98336    98336              
=====================================================
- Hits                   78021    78016       -5     
- Misses                 14838    14842       +4     
- Partials                5477     5478       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariusmihaic mariusmihaic merged commit 5c25b88 into feat/chain-go-sdk Jan 23, 2024
6 of 7 checks passed
@mariusmihaic mariusmihaic deleted the MX-15055-fix-subscribed-events-outgoing-ops branch January 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants