config param update #5828
Merged
config param update #5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/demo-refactor #5828 +/- ##
======================================================
- Coverage 79.22% 79.18% -0.05%
======================================================
Files 772 772
Lines 97282 97282
======================================================
- Hits 77072 77028 -44
- Misses 14733 14777 +44
Partials 5477 5477 ☔ View full report in Codecov by Sentry. |
sasurobert
previously approved these changes
Jan 15, 2024
mariusmihaic
requested changes
Jan 15, 2024
| @@ -158,7 +158,7 @@ | |||
| FrontRunningProtectionEnableEpoch = 1 | |||
|
|
|||
| # IsPayableBySCEnableEpoch represents the epoch when a new flag isPayable by SC is enabled | |||
| IsPayableBySCEnableEpoch = 1 | |||
| IsPayableBySCEnableEpoch = 0 | |||
There was a problem hiding this comment.
This is not enough.
We need more changes in this PR:
- cmd/node/config/config.toml (we will discuss how to address this changes)
- Add these changes:
updateTOMLValue enableEpochs.toml "SCDeployEnableEpoch" 0
updateTOMLValue enableEpochs.toml "BuiltInFunctionsEnableEpoch" 0
updateTOMLValue enableEpochs.toml "ESDTEnableEpoch" 0
- Update go mods for es indexer from this PR: remove checks for metachain nodes in sovereign #5635
mariusmihaic
requested changes
Jan 16, 2024
There was a problem hiding this comment.
This config will not start without vm = 1.5.
- Please create the task we discussed about with over writable configs from prefs.toml for structs.
- In
cmd/node/config/config.toml, for bothWasmVMVersionsentries, use only one entry with this value:{ StartEpoch = 0, Version = "v1.5" },. Also, for both entries, add a TODO with the task id to refactor it with over writable configs once the above mentioned task is completed
mariusmihaic
approved these changes
Jan 30, 2024
raduchis
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?