[core] Fix Netlify build cache issue #43281
Conversation
LukasTy
added
core
Netlify deploy previewhttps://deploy-preview-43281--material-ui.netlify.app/ Bundle size report |
| @@ -9,7 +9,6 @@ | |||
|
|
|||
| [build.environment] | |||
| NODE_VERSION = "18" | |||
| PNPM_FLAGS = "--shamefully-hoist" | |||
There was a problem hiding this comment.
Related discussion: mui/mui-x#14182 (comment)
There was a problem hiding this comment.
From what I understand, Core shouldn't need this flag (see mui/mui-x#14182 (comment))
There was a problem hiding this comment.
Which Netlify functions are we talking about?
cc @michaldudak
mui-x also has a function, which is running without problems. 🤔
Or do you mean this function: https://github.com/mui/material-ui/blob/next/netlify/functions/feedback-management.mts?
AFAIK, all of the dependencies used by this function are in the root package.json. 🤔
There was a problem hiding this comment.
As noted in mui/mui-x#14182 (comment), this now seems to work without the flag, which wasn't the case when I did the pnpm migration.
Replicate the change in: mui/mui-x#14182.
It looks like this setting was the culprit of sporadic Netlify behavior such as pulling a stale cache on some builds.