Skip to content
This repository has been archived by the owner on Oct 22, 2020. It is now read-only.

Add more quotes. #3

Open
mubaris opened this issue Oct 10, 2017 · 95 comments · May be fixed by #224, #296, #362 or #364
Open

Add more quotes. #3

mubaris opened this issue Oct 10, 2017 · 95 comments · May be fixed by #224, #296, #362 or #364

Comments

@mubaris
Copy link
Owner

mubaris commented Oct 10, 2017

No description provided.

@harryjas
Copy link
Contributor

harryjas commented Oct 10, 2017

@mubaris i am working on this.
BTW how much quotes should i add ?

@mubaris
Copy link
Owner Author

mubaris commented Oct 10, 2017

Minimum of 20 😄

@jmeline
Copy link
Contributor

jmeline commented Oct 10, 2017

I've opened a PR with some quotes for you. Let me know if I need to restructure them. Hopefully they won't collide with @harryjas's work.

@mubaris
Copy link
Owner Author

mubaris commented Oct 10, 2017

If you are adding more quotes, add 20 quotes in a new json file in data folder. Then make a PR

mubaris added a commit that referenced this issue Oct 10, 2017
Adding more quotes as requested #3
@hydeenoble
Copy link
Contributor

can more quotes still be added?. I would like to add more.

@mubaris
Copy link
Owner Author

mubaris commented Oct 10, 2017 via email

@hydeenoble
Copy link
Contributor

Great. on it

@harryjas
Copy link
Contributor

harryjas commented Oct 10, 2017

okay..will add in a new json file..

harryjas added a commit to harryjas/motivate that referenced this issue Oct 10, 2017
Added more quotes to data.

Adds to mubaris#3
@AlthafHussainK
Copy link
Contributor

I would like to contribute to this project ✋

@mubaris
Copy link
Owner Author

mubaris commented Oct 11, 2017

Best way to get started is to add more quotes. Fork the repo and add new json file containing 20 quotes. Then send a PR. 😄

@AlthafHussainK
Copy link
Contributor

I've come up with more quotes. Please have a look at it. 😄

@dhanya1
Copy link
Contributor

dhanya1 commented Oct 14, 2017

@mubaris I would like to contribute to this.

@Curchel
Copy link

Curchel commented Oct 14, 2017

i would like to contribute

@EveChen
Copy link

EveChen commented Oct 15, 2017

This project is awesome! I would like to contribute to this
(even though I'm in the beginner level lol).

1st step: Play with it (installing now). :D
2nd step: Find 20 quotes and figure out how to make a json file (I know I should put it into the data folder.)
3rd step: PR - pull a request

I haven't contributed a project on Github before. Although I've already read articles related to "how to contribute to open source projects", you guys can correct me if I do something wrong. >"<

@hydeenoble
Copy link
Contributor

@EveChen you are good to go.... Awesome!

@JayWelborn
Copy link
Contributor

I added some quotes from famous artists about what motivated them to get work done.

@mubaris
Copy link
Owner Author

mubaris commented Oct 16, 2017

@dhanya1 @Curchel Everyone is welcome to contribute. 😄

@fercreek
Copy link
Contributor

I'm on it too!

@ghost
Copy link

ghost commented Oct 19, 2017

Go us!

@maybebored
Copy link
Contributor

Is there a need for more quotes

@jebruen
Copy link

jebruen commented Nov 20, 2018

I would like to contribute!

@IsharaMadhavi
Copy link

This is an interesting project.Can i join to contribute?

@rogonzalez rogonzalez linked a pull request Oct 4, 2019 that will close this issue
@krlakshmikanth
Copy link

I would like to contribute to this project. Why don't we consume API that provides motivational quotes in real-time rather than adding and maintaining a manual inventory? Checkout some API link https://rapidapi.com/HealThruWords/api/universal-inspirational-quotes

@thronecloud
Copy link

thronecloud commented Oct 5, 2019 via email

@esilvaju
Copy link

esilvaju commented Oct 8, 2019

Lets do it !

@cyb3rpr0
Copy link

Hi, I'd like to contribute to this repo as well.

@AdityaSPatil
Copy link

Added 20 new comments. @mubaris

@sQUARys
Copy link

sQUARys commented Oct 13, 2019

Added 20 quotes #337

@enigmaticsoulrg
Copy link

Greetings, I'd like to contribute to this repo (beginner level). This is uplifting and motivating.

@raksh07
Copy link

raksh07 commented Oct 19, 2019

I would like to contribute to this

raksh07 added a commit to raksh07/motivate that referenced this issue Oct 19, 2019
@emmaalecrim
Copy link

Hi, I'm also contributing! Hooray! Gonna make my first PR.

@emmaalecrim emmaalecrim linked a pull request Oct 19, 2019 that will close this issue
@andreinagines andreinagines linked a pull request Oct 20, 2019 that will close this issue
@laurendc
Copy link

Hello, adding my contribution here! #384

@jacksonraniel
Copy link

Hi, everyone! I just did my first PR here. #393

@chrisfoose
Copy link

I want to do this!

@avats-dev
Copy link

Is this still an active issue?

@salmannotkhan
Copy link

what if we setup a scrapper bot to fetch the quotes from a well know quote site??? in that way we can have so many quotes

@kpanic
Copy link

kpanic commented May 24, 2020

Added one more for Dennis Ritchie (DMR) #411
RIP

@kpanic
Copy link

kpanic commented May 24, 2020

@hydeenoble @salmannotkhan
There is some support for that:

For example:

$ python -c 'from quotes_api import ForismaticAPI; import json; print(json.dumps(ForismaticAPI().get_random_quote(), ensure_ascii=False))' motivate/quotes_api.py
# Output manually reformatted, because github does not wrap long lines ;)
{
  'quote': 'Time stays long enough for anyone who will use it.',
  'author': 'Leonardo da Vinci'
}

@adya-13
Copy link

adya-13 commented Aug 26, 2020

Hi, I would like to contribute to it.

@MVAMULYA
Copy link

Hi, I would like to contribute to it

@adya-13
Copy link

adya-13 commented Aug 29, 2020

Hi, this is my first PR here. #419

@avats-dev
Copy link

avats-dev commented Aug 29, 2020

Hey everyone !!

As, this project is not actively maintained now, I've forked it and updated it for the contributors here. This is the concerned issue.
PRs are welcome 🎉.

There is also a new gitter community room for chat in case anyone needs help or to communicate with each other. 👍
Gitter


There are some of you who've already opened PR here, for them:

Just open a new PR with base avats-dev/motivate like below:
change base


For them who are new:


This new repo is active, and I'm maintaining this. Feel free to drop a message on gitter chat if you're stuck or need help.

I would add instructions for FIRST TIMERS in a short while to assist them and get started with OPEN SOURCE.

Thanks everyone for contributions. ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.