Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add headers to interface library #1057

Open
wants to merge 1 commit into
base: cpp_master
Choose a base branch
from

Conversation

timblechmann
Copy link

cmake 3.19 allows headers to be added to interface libraries in order to populate IDE projects

cmake 3.19 allows headers to be added to interface libraries in order to
populate IDE projects
@timblechmann
Copy link
Author

@codecov-commenter
Copy link

Codecov Report

Merging #1057 (2ef4d35) into cpp_master (1edfba0) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           cpp_master    #1057   +/-   ##
===========================================
  Coverage       85.60%   85.60%           
===========================================
  Files              79       79           
  Lines            5023     5023           
===========================================
  Hits             4300     4300           
  Misses            723      723           

@@ -6,6 +6,11 @@ PROJECT (msgpack-cxx LANGUAGES CXX)

ADD_LIBRARY (msgpack-cxx INTERFACE)

IF (CMAKE_VERSION VERSION_GREATER_EQUAL 3.19)
FILE(GLOB_RECURSE SOURCE_FILES include/*hpp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FILE(GLOB_RECURSE SOURCE_FILES include/*hpp)
FILE(GLOB_RECURSE SOURCE_FILES include/*.hpp)

I read https://cmake.org/cmake/help/v3.7/command/file.html globbing-expressions examples.
It seems that *.hpp can avoid unexpected match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants