Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Pass extra parameters to Xacro on the URDF Preview #1210

Open
danieto98 opened this issue Nov 14, 2023 · 2 comments
Open

[feature] Pass extra parameters to Xacro on the URDF Preview #1210

danieto98 opened this issue Nov 14, 2023 · 2 comments
Labels
feature request Suggested features URDF

Comments

@danieto98
Copy link

what is needed
Allow the ROS: Preview URDF command to relay substitution arguments to the xacro command.

why is it needed
When attempting to preview a URDF/Xacro file that makes use of the Rospack command $(arg ...) inside of it, the preview command fails. The current workaround is to manually update the file to replace those arguments before doing the preview, but this is quite tedious and error-prone.

@danieto98 danieto98 added the feature request Suggested features label Nov 14, 2023
@ooeygui ooeygui added the URDF label Jan 8, 2024
@ooeygui
Copy link
Member

ooeygui commented Jan 8, 2024

Thank you for the feature request.
Need to think through the UI for this. Can you suggest how you would expose it?

@danieto98
Copy link
Author

I think for most cases a UI is not necessary, just a way to specify these substitution arguments so that they are appended to the xacro command would be enough. This could be in a config file, or even in the extension settings so they can be written to the settings.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggested features URDF
Projects
None yet
Development

No branches or pull requests

2 participants