Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to support conditional packagereferences #43

Open
mrlacey opened this issue Jan 28, 2024 · 1 comment
Open

Need to support conditional packagereferences #43

mrlacey opened this issue Jan 28, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mrlacey
Copy link
Owner

mrlacey commented Jan 28, 2024

#35 is for a package that doesn't support net8.0 and so can't be referenced in a package that also includes the test project.

Can work around this by setting: <PackageReference Include="Plugin.MauiMTAdmob" Version="1.1.1" Condition="'$(TargetFramework)' != 'net8.0'" />

However, the current generator code doesn't support setting a condition for a package added via the add Nuget package postaction.
Look at modifying/extending the postaction, or adding a new postaction that can run afterwards and set the condition.

@mrlacey mrlacey added the enhancement New feature or request label Jan 28, 2024
@mrlacey mrlacey self-assigned this Jan 28, 2024
@mrlacey mrlacey added this to the 1.5 milestone Jan 28, 2024
@mrlacey
Copy link
Owner Author

mrlacey commented Mar 31, 2024

@mrlacey mrlacey removed this from the 1.5 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant