Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode and CollectionView DataTemplate #41

Open
VeryKross opened this issue Nov 28, 2023 · 3 comments
Open

Dark Mode and CollectionView DataTemplate #41

VeryKross opened this issue Nov 28, 2023 · 3 comments
Assignees
Labels
bug Something isn't working question Further information is requested
Milestone

Comments

@VeryKross
Copy link

Describe the bug
The generated CollectionView DataTemplate for ListDetail is unreadable when run on an OS set to Dark Mode. This has been reproduced under both Windows and iOS.

To Reproduce
Steps to reproduce the behavior:

  1. Generate the default app template that includes the ListDetail page.
  2. Run the app on a Windows or iOS machine set to use Dark Mode
  3. The list will effectively render with black text on a black background

Expected behavior
Text should be reasonably colored (foreground and background) as appropriate to both Light and Dark modes on all platforms.

Screenshots
image
image
image

Versions (please complete the following information):

  • OS: Windows 11 and iOS 17
  • Visual Studio version 2022
  • Extension Version [e.g. 1.0 -- it's in the bottom-righthand corner of the wizard]: 1.3.3

Additional context
Just removing the TextColor setting in the DataTemplate appears to resolve the issue.

@VeryKross VeryKross added the bug Something isn't working label Nov 28, 2023
@mrlacey mrlacey self-assigned this Nov 28, 2023
@mrlacey
Copy link
Owner

mrlacey commented Nov 28, 2023

Thanks for reporting.
I'm now wondering why this was ever included or if it ever worked...I'll investigate

@mrlacey
Copy link
Owner

mrlacey commented Nov 28, 2023

Hmmm.
I can't repro this.

Here's the app running on Win11 in both light and dark modes.

image

image

In both, the frame background is white so that you're not seeing this at all in your screenshots makes me wonder if any content has loaded at all.

If I remove the setting of the TextColor I get this:

image
image

Please can you share your generated project to allow me to investigate further.

@VeryKross
Copy link
Author

Hmm... that's very odd. Alright, I'll gen up a new project with the latest release and see if it still repros here. I'll also screen shot the selections I make along the way in case that makes a difference. I'll let you know either way.

@mrlacey mrlacey added the question Further information is requested label Jan 28, 2024
@mrlacey mrlacey added this to the backlog milestone Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants