Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't hoist static #29

Closed
pencilcheck opened this issue Jul 8, 2017 · 3 comments
Closed

Doesn't hoist static #29

pencilcheck opened this issue Jul 8, 2017 · 3 comments

Comments

@pencilcheck
Copy link

i'm on nextjs, this package doesn't hoist getInitialProps, which is a non react static method.

@pencilcheck
Copy link
Author

pencilcheck commented Jul 8, 2017

Very likely Babel/ES6 is not making static method enumerable. Perhaps this is something that this package cannot work without some configuration from babel:

https://babeljs.io/docs/plugins/transform-class-properties/

If so, some warning in the README would be appreciated.

@mridgway
Copy link
Owner

mridgway commented Jul 9, 2017

I am actively looking into this. I consider this a regression in 2.x. I will be adding support for static methods even if the spec and/or Babel does not make them enumerable.

@pencilcheck
Copy link
Author

Thanks, confirmed that it works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants