Work around newer CMake and MSVC support #89
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two CMake warnings when using newer CMake(above 3.5) and the wrong order of
cmake_minimum_required
(should be the first line)In order to maintain compatibility with lower versions of CMake and eliminate warnings, the order of CMake statements was changed and the
<min>...<max>
form was used to set the version range.In VS 2015 and newer, the
snprintf
is supported, so there is no need to add define by-Dsnprintf=_snprintf
, which can be found in hereThe corresponding
MSVC_VERSION
forMSVC
can be found here. Although i have not tested it on lower versions of Visual Studio, it should work.I tested in MSVC 2019 and 2022 with CMake 3.29.3.