Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Configs #102

Open
ax3l opened this issue Jul 3, 2017 · 4 comments
Open

Install Configs #102

ax3l opened this issue Jul 3, 2017 · 4 comments
Assignees

Comments

@ax3l
Copy link

ax3l commented Jul 3, 2017

Currently, make install only installs the benchmark binaries but not the default configurations. In order to let gearshifft run out-of-the-box when installed (spack, debian package, etc.), one might also need to install the config files (e.g. extents.csv).

The right place would be share/gearshifft/ or etc/gearshifft/ in *nix systems, prepended by the CMAKE_PREFIX_PATH.
You might also want to reflect the same structure for simplicity in the source-directory, too.

This will change the default path of the -f parameter of your tools. Ideally it is not ../share/gearshifft/extents.csv relative to the calling shell's pwd but <pathOfBinary>/../share/gearshifft/extents.csv of the called executable that is installed in CMAKE_PREFIX_PATH.

@ax3l
Copy link
Author

ax3l commented Jul 3, 2017

update: oh wait, I just saw there seems to be a fallback to some defaults if the file is missing. So you can keep the -f syntax but installing example configs might still be a good idea!

@tdd11235813
Copy link
Contributor

yeah, as you pointed out there might be some pitfalls which I want to test, so the config files have not been included in the install process yet. Thanks for your support! I want to release a new version next week.

@ax3l
Copy link
Author

ax3l commented Jul 5, 2017

sure, but I just figured out that you already provide a default fallback, so for a first install the binaries alone are already useful :)

@tdd11235813 tdd11235813 self-assigned this Jul 10, 2017
@tdd11235813
Copy link
Contributor

Pull Request #110 implements cmake installation of the FFT configs. Check out if you have time or wait for the next pre-release.

A propos releasing. Probably it is better to wait for @psteinb to separate the gearshifft source and results into two projects as mentioned in issue #105 . If time permits I implement a small test environment. Afterwards travis would follow.

tdd11235813 added a commit that referenced this issue Jul 17, 2017
Install FFT Configs (resolves Issue #102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants