Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Privacy Manifest support for iOS 17 #19

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Fix parsing issue due to empty dict
  • Ensure manifest is included using all 3 package managers
  • Note the partner SDK doesn't properly include their privacy manifest when using CocoaPods yet, but our dependency should auto-update as soon as they do. I've already reported the issue here with recommendations: Add Privacy Manifest Iterable/iterable-swift-sdk#750 (comment))

Testing Plan

  • Was this tested locally? If not, explain why.
  • Confirmed in test apps using SPM, CocoaPods, and Carthage.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit e6235c3 into development Apr 29, 2024
3 checks passed
@einsteinx2 einsteinx2 deleted the feat/6401-improve-privacy-manifest-support branch April 29, 2024 20:25
mparticle-automation added a commit that referenced this pull request Apr 29, 2024
# [8.6.0](v8.5.0...v8.6.0) (2024-04-29)

### Features

* Improve Privacy Manifest support for iOS 17 ([#19](#19)) ([e6235c3](e6235c3))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants