Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Serial position #959

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Update Serial position #959

merged 2 commits into from
Jan 10, 2024

Conversation

bgrins
Copy link
Member

@bgrins bgrins commented Jan 10, 2024

No description provided.

@bgrins
Copy link
Member Author

bgrins commented Jan 10, 2024

Fixes #687

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this accurately reflects our updated experience and more cautious method for approaching these sorts of specifications. Approving without merging to get more reviews because this is a more long-running / sensitive shift than usual.

@bholley
Copy link
Collaborator

bholley commented Jan 10, 2024

LGTM

@bgrins bgrins merged commit 5e6937f into mozilla:main Jan 10, 2024
1 check passed
@Ferdi265
Copy link

With this merged, will Mozilla reconsider their stance of not implementing WebSerial (as per this bug) and potentially implement it in a similar add-on gated way to WebMIDI?

@bholley
Copy link
Collaborator

bholley commented May 9, 2024

With this merged, will Mozilla reconsider their stance of not implementing WebSerial (as per this bug) and potentially implement it in a similar add-on gated way to WebMIDI?

This PR represents a reconsideration of our stance. We'd take a patch, assuming we think the proposed language in the prompt is sufficiently clear and assuming the patch otherwise met all of our usual standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants