Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS ALB recommendations for Intermediate and Modern need updating #211

Closed
markstuart opened this issue Nov 22, 2023 · 7 comments
Closed
Assignees
Labels
compatibility Warnings, deprecations or incompatibilities to tackle enhancement New feature or request

Comments

@markstuart
Copy link

Intermediate

The awsalb 2019.8.1, intermediate config recommends using the "ELBSecurityPolicy-FS-1-2-Res-2019-08" for the listener ssl policy. That policy doesn't support TLS 1.3, but the intermediate config really should I think.

Matching the recommended protocols and ciphers for nginx 1.17.7, intermediate config, OpenSSL 1.1.1k the ALB listener policy that is the closest looks like ELBSecurityPolicy-TLS13-1-2-Ext1-2021-06

See https://docs.aws.amazon.com/elasticloadbalancing/latest/network/create-tls-listener.html#tls-protocols-ciphers for cipher coverage in the table.

Modern

The awsalb 2019.8.1, modern config states that "unfortunately, AWS ALB does not support the modern configuration"

Looking at the available listener policies, the only one that AWS provides that restricts to TLS1.3 only is "ELBSecurityPolicy-TLS13-1-3-2021-06"

@janbrasna
Copy link
Collaborator

There's an open PR #198 to address the issue.

@markstuart There's only a slight difference in the intermediate policy chosen,

ELBSecurityPolicy-TLS13-1-2-Ext1-2021-06 that you recommend
vs.
ELBSecurityPolicy-TLS13-1-2-2021-06 in the PR

Can you elaborate on the difference or maybe review the PR to discuss the ideal setup with the author?

@janbrasna
Copy link
Collaborator

janbrasna commented Feb 2, 2024

Based on the overview table:

Screen Shot 2024-02-02 at 17 41 57

the -Ext1- includes weak suites as TLS_RSA_WITH_AES_128_CBC_SHA256 or TLS_RSA_WITH_AES_128_GCM_SHA256 so that shouldn't be used. 🚫

In reality it should be the more restricted -Res- policy, to get rid of all the CBC suites… ✅ → #198 (review)

@amznmunchy
Copy link

Hi team, TLS13-1-3-2021-06 (TLS v1.3 only) is now supported by ALBs.

Screenshot 2024-02-29 at 8 58 27 am

@janbrasna
Copy link
Collaborator

@amznmunchy The support for modern (TLSv1.3 only) is being added in #198. We're also looking into updates for ELB, would you mind checking #84 (comment) if you have access to the cli to get the supported ciphers? Thanks.

@amznmunchy
Copy link

@janbrasna Thank you for the update! Classic Load Balancers support the following cipher suites:

Screenshot 2024-02-29 at 1 12 42 pm

@gstrauss
Copy link
Collaborator

gstrauss commented Oct 4, 2024

Fixed by #198

@gstrauss gstrauss closed this as completed Oct 4, 2024
@janbrasna janbrasna self-assigned this Oct 4, 2024
@janbrasna janbrasna added enhancement New feature or request compatibility Warnings, deprecations or incompatibilities to tackle labels Oct 4, 2024
@janbrasna
Copy link
Collaborator

@amznmunchy Thanks for the overview. We nonetheless use a custom policy, so we're picking from a different set of available ciphers, for ELB they're FYI defined here: https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-ssl-security-policy.html#ssl-ciphers
(as the predefined policies for ELBs are nowhere near the ones we use for ALBs, so we have to build custom ones for Classic…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Warnings, deprecations or incompatibilities to tackle enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants